Ludo java21 #9882
Ludo java21 #9882
Conversation
product-auto-label
bot
added
samples
|
Gemini encountered an error creating the summary. You can try again by commenting |
|
@code-review-assist summarize |
![code-review-assist[bot]](https://avatars.githubusercontent.com/in/1008254?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi @ludoch, Gemini is currently reviewing this pull request and will post a full review in a few minutes. In the meantime, here's a quick summary for you and other reviewers:
This pull request migrates all Java 8 App Engine samples to the latest Java 21 runtime. The goal is to update the samples to a supported runtime, while minimizing changes to the core servlet code. The primary changes involve modifying the appengine-web.xml files in each sample to specify the Java 21 runtime and using the compatible EE8 setting. Additionally, several README.md files have been updated to reflect the Java 21 runtime. The pom.xml files in several samples have also been updated to reflect the new artifact IDs.
Specifically, the following files were modified:
appengine-java21/README.mdappengine-java21/analytics/README.md,appengine-java21/analytics/pom.xml,appengine-java21/analytics/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/appidentity/README.md,appengine-java21/appidentity/pom.xml,appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/IdentityServlet.java,appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/SignForAppServlet.java,appengine-java21/appidentity/src/main/java/com/example/appengine/appidentity/UrlShortener.java,appengine-java21/appidentity/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/bigquery/README.md,appengine-java21/bigquery/pom.xml,appengine-java21/bigquery/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/bigtable/README.md,appengine-java21/bigtable/build.gradle,appengine-java21/bigtable/pom.xml,appengine-java21/bigtable/settings.gradle,appengine-java21/bigtable/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/bigtable/src/main/webapp/WEB-INF/logging.properties,appengine-java21/bigtable/src/main/webapp/bigtable.jspappengine-java21/cloudsql/README.mdappengine-java21/datastore-indexes-exploding/pom.xml,appengine-java21/datastore-indexes-exploding/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/datastore-indexes-perfect/pom.xml,appengine-java21/datastore-indexes-perfect/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/datastore-indexes/pom.xml,appengine-java21/datastore-indexes/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/datastore-schedule-export/cron.yaml,appengine-java21/datastore-schedule-export/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/datastore-schedule-export/src/main/webapp/WEB-INF/logging.properties,appengine-java21/datastore-schedule-export/src/main/webapp/index.jspappengine-java21/datastore/README.md,appengine-java21/datastore/pom.xml,appengine-java21/datastore/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/datastore/src/test/java/com/example/appengine/QueriesTest.javaappengine-java21/firebase-tictactoe/README.md,appengine-java21/firebase-tictactoe/pom.xml,appengine-java21/firebase-tictactoe/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/firebase-tictactoe/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/gaeinfo/README.md,appengine-java21/gaeinfo/pom.xml,appengine-java21/gaeinfo/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/gaeinfo/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/guestbook-cloud-datastore/README.md,appengine-java21/guestbook-cloud-datastore/pom.xml,appengine-java21/guestbook-cloud-datastore/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/guestbook-cloud-datastore/src/main/webapp/WEB-INF/index.yaml,appengine-java21/guestbook-cloud-datastore/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/iap/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/images/README.md,appengine-java21/images/pom.xml,appengine-java21/images/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/mail/pom.xml,appengine-java21/mail/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/mail/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/mailgun/README.md,appengine-java21/mailgun/pom.xml,appengine-java21/mailgun/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/mailjet/README.md,appengine-java21/mailjet/pom.xml,appengine-java21/mailjet/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/memcache/pom.xml,appengine-java21/memcache/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/metadata/README.md,appengine-java21/metadata/pom.xml,appengine-java21/metadata/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/oauth2/README.md,appengine-java21/oauth2/pom.xml,appengine-java21/oauth2/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/pubsub/README.md,appengine-java21/pubsub/src/main/java/com/example/appengine/pubsub/PubSubAuthenticatedPush.java,appengine-java21/pubsub/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/remote-README.md,appengine-java21/remote-client/pom.xml,appengine-java21/remote-server/pom.xml,appengine-java21/remote-server/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/requests/README.md,appengine-java21/requests/pom.xml,appengine-java21/requests/src/main/java/com/example/appengine/requests/LoggingServlet.java,appengine-java21/requests/src/main/java/com/example/appengine/requests/RequestsServlet.java,appengine-java21/requests/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/search/README.md,appengine-java21/search/pom.xml,appengine-java21/search/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/sendgrid/README.md,appengine-java21/sendgrid/pom.xml,appengine-java21/sendgrid/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/spanner/README.md,appengine-java21/spanner/pom.xml,appengine-java21/spanner/src/main/webapp/WEB-INF/appengine-web.xmlappengine-java21/sparkjava-helloworld/README.md,appengine-java21/sparkjava-helloworld/pom.xml,appengine-java21/sparkjava-helloworld/src/main/java/HelloWorld.java,appengine-java21/sparkjava-helloworld/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/sparkjava-helloworld/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/springboot-helloworld/.mvn/wrapper/maven-wrapper.properties,appengine-java21/springboot-helloworld/lombok.config,appengine-java21/springboot-helloworld/mvnw,appengine-java21/springboot-helloworld/mvnw.cmd,appengine-java21/springboot-helloworld/pom.xml,appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/AppEngineConfig.java,appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/HelloworldController.java,appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/ServletInitializer.java,appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/SpringBootExampleApplication.java,appengine-java21/springboot-helloworld/src/main/java/com/example/appengine/demos/springboot/WebAppConfiguration.java,appengine-java21/springboot-helloworld/src/main/resources/application.yml,appengine-java21/springboot-helloworld/src/main/resources/logging.properties,appengine-java21/springboot-helloworld/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/springboot-helloworld/src/main/webapp/WEB-INF/datastore-indexes.xml,appengine-java21/springboot-helloworld/src/main/webapp/WEB-INF/jsp/index.jsp,appengine-java21/springboot-helloworld/src/main/webapp/WEB-INF/web.xml,appengine-java21/springboot-helloworld/src/test/java/com/example/appengine/demos/springboot/SpringBootExampleApplicationTests.javaappengine-java21/static-files/pom.xml,appengine-java21/static-files/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/static-files/src/main/webapp/index.htmlappengine-java21/taskqueues-deferred/README.md,appengine-java21/taskqueues-deferred/pom.xml,appengine-java21/taskqueues-deferred/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/taskqueues-deferred/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/taskqueues-pull/README.md,appengine-java21/taskqueues-pull/pom.xml,appengine-java21/taskqueues-pull/src/main/webapp/WEB-INF/appengine-web.xml,appengine-java21/taskqueues-pull/src/main/webapp/WEB-INF/logging.propertiesappengine-java21/taskqueues-push/README.md,appengine-java21/taskqueues-push/pom.xml,appengine-java21/taskqueues-push/src/main/webapp/WEB-INF/appengine-web.xml
This is a significant update, so thorough testing is crucial. Let me know if you have any questions.
Small changes, big impact,
Java's new version's a pact,
Modernizing code's art.
|
We need to wait that cl/691482072 is also done, and will need to coordinate the 2 changes at the same time. |
|
Also, I cannot see any more information about the check "Inclusive Language Completed in 21s — Check failed due to error" |
| @@ -1,7 +1,7 @@ | |||
| App Engine Java Guestbook | |||
| Copyright (C) 2010-2012 Google Inc. | |||
There was a problem hiding this comment.
can you modify this to be the correct format for showing copyright with just the first year and not the span.
|
looks like we need to fix [ERROR] Failed to execute goal on project gaeinfo-j21: Could not resolve dependencies for project com.example.appengine:gaeinfo-j21:war:1.0-SNAPSHOT: Could not transfer artifact com.squareup.okhttp3:okhttp:jar:4.12.0 from/to central (https://repo.maven.apache.org/maven2): GET request of: com/squareup/okhttp3/okhttp/4.12.0/okhttp-4.12.0.jar from central failed: Connection reset -> [Help 1] |
|
snippetbot is complaining because a lot of region tags need the gae prefix. can you either remove the region tags (if they aren't used anymore or needed, might be a space for improvements to documentation) or rename to append the gae product prefix? |
So we are saying that all these added regions over the last 10+ years are not correct? Not sure how I can verify the correctness of tags. Where is the list of valid tags? Where is it documented, I want to put the correct strings. |
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2015 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
leave the year to 2015. Inc to LLC is correct.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2016 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
keep copyright year as 2016
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2016 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
keep copyright year as original
| <img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a> | ||
|
|
||
| # Google Cloud API Showcase: BigQuery & Cloud Monitoring in App Engine standard environment for Java 8 | ||
| # Google Cloud API Showcase: BigQuery & Cloud Monitoring in App Engine standard environment for Java 21 | ||
|
|
||
| This API Showcase demonstrates how to run an App Engine standard environment application with dependencies on both |
There was a problem hiding this comment.
I think [StackDriver Monitoring] needs to get updated to Cloud Monitoring
| @@ -1,5 +1,5 @@ | |||
| <!-- | |||
| Copyright 2018 Google Inc. | |||
| Copyright 2024 Google LLC | |||
There was a problem hiding this comment.
leave the original copyright year
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
...e-java21/bigquery/src/main/java/com/example/appengine/bigquerylogging/TimeSeriesSummary.java
Show resolved
Hide resolved
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2018 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2016 Google Inc. | |||
| * Copyright 2024 Google LLC | |||
appengine-java21/bigtable/src/main/java/com/example/bigtable/BigtableHelper.java
Show resolved
Hide resolved
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <!-- | |||
| Copyright 2016 Google Inc. | |||
| Copyright 2024 Google LLC | |||
| @@ -3,7 +3,7 @@ | |||
| <%@ page import="com.example.bigtable.BigtableHelloWorld" %> | |||
| <!-- [START_EXCLUDE] --> | |||
| <%-- | |||
| ~ Copyright 2017 Google Inc. | |||
| ~ Copyright 2024 Google LLC | |||
appengine-java21/datastore-indexes-perfect/src/main/webapp/WEB-INF/appengine-web.xml
Show resolved
Hide resolved
| @@ -19,9 +19,9 @@ | |||
| # To use this configuration, copy it into your application's WEB-INF | |||
| # folder and add the following to your appengine-web.xml: | |||
| # | |||
| # <system-properties> | |||
| # <system-properties> | |||
There was a problem hiding this comment.
this also looks like an accidental change
Description
Move all GAE java8 runtime (which is now EOL) to the latest GAE java21 runtime, using the compatible EE8 setting.
This way, the java source code should not change (i.e same servlets code), and only the xml config files, like appengine-web.xml are changed.
Manually tested with local devappserver as well as deployed to my cloud project.
Cannot submit without doing the Google public pages changes seen in pending cl/691482072 internally.
I am coordinating with the Google Cloud doc folks.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only