feat(compute): add compute disk create secondary regional sample #9641

TetyanaYahodska · 2024-11-03T14:20:12Z

Description

Documentation - https://cloud.google.com/compute/docs/disks/async-pd/configure?authuser=0#gcloud

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

snippet-bot · 2024-11-04T09:40:16Z

Here is the summary of changes.

You are about to add 1 region tag.

compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java:19, tag compute_disk_create_secondary_regional

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

Sita04 · 2024-12-18T20:45:10Z

compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java

+
+      // Wait for the create disk operation to complete.
+      Operation response = disksClient.insertAsync(secondaryProjectId, secondaryDiskRegion, disk)
+          .get(3, TimeUnit.MINUTES);


Are we sure this Operation only takes 3 minutes to run?

As for other operations, 3 minutes was enough.

Is it the same case with this operation as well? We don't want flaky tests.

We also set it to 3 minutes for other disk creation operations. Why should it be different in this case?

Just confirming if this is enough time. Not opposing your claim.

There is enough time. The test passed without errors.

Sita04 · 2024-12-18T21:01:11Z

compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java

+      throws IOException, ExecutionException, InterruptedException, TimeoutException {
+    // An iterable collection of zone names in which you want to keep
+    // the new disks' replicas. One of the replica zones of the clone must match
+    // the zone of the source disk.


I don't think this is mandatory. Kindly remove this comment and let the docs describe about the requirements.

Thank you! Deleted

Sita04 · 2024-12-18T21:21:28Z

compute/cloud-client/src/main/java/compute/disks/CreateDiskSecondaryRegional.java

+    DiskAsyncReplication asyncReplication = DiskAsyncReplication.newBuilder()
+        .setDisk(primaryDiskSource)
+        .build();


Kindly move this code within the try block

Thank you! Fixed

Sita04 · 2024-12-23T06:02:55Z

compute/cloud-client/src/test/java/compute/disks/DisksIT.java

@@ -317,6 +317,7 @@ public void testCreateReplicatedDisk()
            replicaZones, REGIONAL_REPLICATED_DISK, 100, DISK_TYPE);

    assertThat(status).isEqualTo(Status.DONE);
+    assertThat(status).isEqualTo(Status.DONE);


Why is this assert statement duplicated here?

It's a mistake. Thank you! Deleted

* chore(job): migrate regions by associating them with an official product with a job_ prefix (#9883) * chore(endpoints): delete region 'swagger' in endpoints/multiple-versions (#9857) * chore(endpoints): delete region swagger to openapi-v1.yaml * chore(endpoints): delete region swagger to openapi-v2.yaml * chore(job): delete sample jobs_java_dependencies_beta (#9810) * chore(job): delete sample jobs_java_dependencies_beta * chore(job): delete region_tab 'jobs_java_dependencies_beta' and update 'google-api-services-jobs' version * feat(compute): add compute disk regional replicated sample (#9697) * Implemented compute_disk_regional_replicated sample, created test * Fixed zone * Fixed test * Fixed test * Fixed disk size * Fixed code as requested in the comment * feat(compute): add compute disk start/stop replication samples (#9650) * Implemented compute_disk_start_replication and compute_disk_stop_replication samples, created tests * Fixed test * Deleted not related classes * Fixed lint issue * Increased timeout * Split samples for zonal location * Fixed code * Fixed code * Increased timeout * Increased timeout * feat(tpu): add tpu vm create spot sample. (#9610) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_spot sample, created test * changed zone * Changed zone * Fixed empty lines and tests, deleted cleanup method * Changed zone * Deleted redundant test class * Increased timeout * Fixed test * feat(tpu): add tpu vm create startup script sample. (#9612) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_vm_create_startup_script sample, created test * Fixed tests and empty lines * Changed zone * Deleted redundant test classes * Increased timeout * Fixed code * feat(tpu): add tpu queued resources create/get/delete samples (#9613) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Fixed test * Fixed tests * Fixed error massage * Fixed typo * Fixed zone * Fixed test * Fixed code * Deleted commented imports * Fixed code as requested in comments * feat(tpu): add tpu queued resources create spot (#9615) Add a code sample for tpu_queued_resources_create_spot * chore: add translate dev team for translate samples (#9888) b/385243174 * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Create, Delete, List, Get) (#9743) * sample codes for event threat detection custom modules * addressed comments * addressed comments * addressed comments * addressed comments * fix(compute): fixed compute_reservation_create_shared sample and test to use mocked client (#9840) * Fixed sample and test to use mocked client * Fixed code as requested in the comments * feat(compute): add compute instance create replicated boot disk sample (#9735) * Implemented compute_instance_create_replicated_boot_disk sample, created test * Fixed test * Fixed code as requested in the comments * Fixed Util class * Fixed code * feat(compute): add compute consistency group stop replication (#9694) * Implemented compute_consistency_group_create and compute_consistency_group_delete samples, created test * Implemented compute_consistency_group_stop_replication sample * Implemented compute_consistency_group_stop_replication sample * Created test and added needed classes for testing * Fixed test * Moved clean up methods * Added clean up methods for reservations * Fixed clean up method * Fixed clean up method * Added timeout * Reverted not related changes * Reverted not related changes * Reverted not related changes * Reverted not related changes * Fixed code * Split samples for zonal location * Added comments for methods * Fixed comments * feat(secretmanager): add optional ttl to create secret sample (#9889) * feat(secretmanager): add optional ttl to create secret sample * nit: Update secretmanager/src/main/java/secretmanager/CreateSecret.java Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * fix(secretmanager): fix comment indentation to resolve linting issues --------- Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> * feat(tpu): add tpu queued resources list sample (#9614) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_list sample, created test * Fixed test * Fixed tests, deleted cleanup method * Fixed test * Fixed imports * feat(compute): add compute disk create secondary regional sample (#9641) * Implemented compute_disk_create_secondary_regional. created test * Fixed test * Fixed test * Fixed test * Fixed zone * Fixed naming * Fixed spaces * Fixed code * Fixed indentations * Fixed variable * Fixed code * Added cleanup methods * Fixed lint issue * Fixed lint issue * Fixed test * Fixed code * Fixed code * Fixed code * Deleted duplicated assertion * feat(compute): add compute disk create secondary sample. (#9643) * Implemented compute_disk_create_secondary sample, created test * Fixed code * Fixed variable * Fixed code * Merged changes from main * Fixed lint issue * fix(storage): migrate old region all to storagetransfer_transfer_all step 1 (#9917) * fix(job): remove old region create_job (#9914) * feat(compute): attach/ remove snapshot schedule to disk (#9791) * Implemented compute_snapshot_schedule_attach sample, created test * Implemented compute_snapshot_schedule_remove sample, created test * Fixed code * Fixed code as requested in the comments * feat(compute): add compute consistency group clone sample (#9885) * Implemented compute_consistency_group_clone and compute_consistency_group_clone_regional_disk samples, created tests * Fixed naming * feat(compute): add compute instance attach regional disk force sample (#9730) * Implemented compute_instance_attach_regional_disk_force sample, created test * Added clean up method * Fixed comments and parameters * Test order deleted * Fixed code * Fixed code * Fixed code * Increased timeout * Increased timeout * Increased timeout * Fixed code * Fixed code * Fixed code * Fixed naming * feat(compute): add compute disk create secondary custom sample (#9644) * Implemented compute_disk_create_secondary_custom sample, created test * Fixed code * Fixed variable * Fixed code * Fixed whitespace * Fixed whitespace * feat(compute): add compute snapshot schedule create/get/edit/list/delete samples (#9742) * Implemented compute_snapshot_schedule_delete and compute_snapshot_schedule_create samples, created test * Fixed test * Added compute_snapshot_schedule_get sample, created test * Fixed naming * Implemented compute_snapshot_schedule_edit, created test * Fixed naming * Implemented compute_snapshot_schedule_list sample, created test * Cleaned resources * Cleaned resources * Cleaned resources * Cleaned resources * Fixed test * Added comment * Fixed tests * Fixed code * Fixed code as requested in the comments * feat(compute): add compute disk create with snapshot schedule (#9788) * Implemented compute_disk_create_with_snapshot_schedule sample, created test * Fixed code * Fixed code * Fixed test * Fixed code * Fixed code as requested in the comments * Fixed lint issue * Fixed lint issue * Deleted redundant code * feat(tpu): add tpu queued resources time bound sample. (#9617) * Changed package, added information to CODEOWNERS * Added information to CODEOWNERS * Added timeout * Fixed parameters for test * Fixed DeleteTpuVm and naming * Added comment, created Util class * Fixed naming * Fixed whitespace * Split PR into smaller, deleted redundant code * Implemented tpu_queued_resources_create, tpu_queued_resources_get, tpu_queued_resources_delete_force and tpu_queued_resources_delete samples, created tests * Implemented tpu_queued_resources_time_bound sample, created test * Changed zone for tpu * Cleanup resources * Fixed tests * Fixed test * Fixed code as requested in the comments * Fixed code as requested in the comments * fix(job): delete old region tag update_job_with_field_mask (#9940) * feat(job): migrate region tags to include product prefix (#9966) * fix(endpoints): migrate all regions (#9943) * fix: disable flakybot reporting (#9968) * chore(job): remove unused region tags (#9969) * feat(securitycenter): Add Resource SCC Management API Org ETD Custom Module code samples (Update, Get Eff, List Eff, List Desc, Validate) (#9912) * sample codes for event threat detection custom modules * fixed lint * addressed comments * lint fix * addressed comments --------- Co-authored-by: OremGLG <[email protected]> Co-authored-by: eapl.me <[email protected]> Co-authored-by: Тетяна Ягодська <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: lovenishs04 <[email protected]> Co-authored-by: alarconesparza <[email protected]> Co-authored-by: Jennifer Davis <[email protected]> Co-authored-by: code-review-assist[bot] <182814678+code-review-assist[bot]@users.noreply.github.com> Co-authored-by: Brian Dorsey <[email protected]>

TetyanaYahodska added 2 commits November 2, 2024 15:09

Implemented compute_disk_create_secondary_regional. created test

cfd7a6c

Fixed test

c6a4006

product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels Nov 3, 2024

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2024

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 3, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2024

Fixed test

316add2

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2024

Fixed test

3f7445c

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 3, 2024

Fixed zone

668752f

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2024

TetyanaYahodska marked this pull request as ready for review November 4, 2024 09:40

TetyanaYahodska requested review from yoshi-approver and a team as code owners November 4, 2024 09:40

blunderbuss-gcf bot assigned kweinmeister Nov 4, 2024

TetyanaYahodska assigned Sita04 and unassigned kweinmeister Dec 10, 2024

TetyanaYahodska requested a review from Sita04 December 10, 2024 10:38

Resolved merge conflict

64c15f3

TetyanaYahodska added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2024

kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 18, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024

Fixed code

545b7ef

Sita04 requested changes Dec 18, 2024

View reviewed changes

TetyanaYahodska added 2 commits December 18, 2024 22:49

Fixed code

d863a9a

Fixed code

9262c78

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 18, 2024

Resolved merge conflict

025ab5a

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024

Sita04 requested changes Dec 23, 2024

View reviewed changes

TetyanaYahodska added 2 commits December 23, 2024 12:24

Deleted duplicated assertion

1b75b5e

Merge branch 'main' into compute_create_secondary_disk

64c2cc6

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 23, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 23, 2024

Merge branch 'main' into compute_create_secondary_disk

cac1ffd

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 23, 2024

TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 23, 2024

Sita04 approved these changes Dec 27, 2024

View reviewed changes

TetyanaYahodska merged commit 0795de2 into main Dec 27, 2024
10 checks passed

TetyanaYahodska deleted the compute_create_secondary_disk branch December 27, 2024 09:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compute): add compute disk create secondary regional sample #9641

feat(compute): add compute disk create secondary regional sample #9641

TetyanaYahodska commented Nov 3, 2024 •

edited

Loading

snippet-bot bot commented Nov 4, 2024 •

edited

Loading

Sita04 Dec 18, 2024

TetyanaYahodska Dec 18, 2024

Sita04 Dec 23, 2024

TetyanaYahodska Dec 23, 2024

Sita04 Dec 27, 2024

TetyanaYahodska Dec 27, 2024

Sita04 Dec 18, 2024

TetyanaYahodska Dec 18, 2024

Sita04 Dec 18, 2024

TetyanaYahodska Dec 18, 2024

Sita04 Dec 23, 2024

TetyanaYahodska Dec 23, 2024

feat(compute): add compute disk create secondary regional sample #9641

feat(compute): add compute disk create secondary regional sample #9641

Conversation

TetyanaYahodska commented Nov 3, 2024 • edited Loading

Description

Checklist

snippet-bot bot commented Nov 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TetyanaYahodska commented Nov 3, 2024 •

edited

Loading

snippet-bot bot commented Nov 4, 2024 •

edited

Loading