Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created src/main/java/discoveryengine/v1/CreateDataStore.java #9529

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Created src/main/java/discoveryengine/v1/CreateDataStore.java #9529

wants to merge 5 commits into from

Conversation

holtskinner
Copy link
Contributor

This code was written by Gemini ✨

@holtskinner holtskinner requested review from yoshi-approver and a team as code owners September 23, 2024 16:00
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 23, 2024
@holtskinner holtskinner added the generated: genai Contains Generative AI based code, requesting an additional reviewer. label Sep 23, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Sep 23, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@briandorsey
Copy link
Member

I'm removing myself as a reviewer since I don't have enough Java knowledge to review.

On the GenAI side, I think the two samples need a comment mentioning that the code was generated by Gemini.

@briandorsey briandorsey removed their assignment Oct 7, 2024
@telpirion
Copy link
Contributor

@holtskinner We should probably chat privately about this PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@telpirion telpirion

Labels
generated: genai Contains Generative AI based code, requesting an additional reviewer. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holtskinner @briandorsey @telpirion