Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generativeaionvertexai_stream_text_basic #9430

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: generativeaionvertexai_stream_text_basic #9430

merged 1 commit into from
Aug 1, 2024

Conversation

TetyanaYahodska
Copy link
Contributor

@TetyanaYahodska TetyanaYahodska commented Aug 1, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 1, 2024
@TetyanaYahodska TetyanaYahodska added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 1, 2024
@glaforge
Copy link
Contributor

glaforge commented Aug 1, 2024

Sounds good to me, and more aligned with the other language samples.

@TetyanaYahodska TetyanaYahodska marked this pull request as ready for review August 1, 2024 12:03
@TetyanaYahodska TetyanaYahodska requested review from yoshi-approver and a team as code owners August 1, 2024 12:03
@TetyanaYahodska TetyanaYahodska requested a review from Sita04 August 1, 2024 12:03
@TetyanaYahodska TetyanaYahodska merged commit 19adb6f into main Aug 1, 2024
11 checks passed
@TetyanaYahodska TetyanaYahodska deleted the generativeaionvertexai_stream_text_basic branch August 1, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@kweinmeister kweinmeister

@Sita04 Sita04

Labels
kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TetyanaYahodska @glaforge @Sita04 @kweinmeister