updating Firebase on App Engine sample to use latest libs #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing issue in running locally
googlebot
added
the
cla: yes
lesv
approved these changes
Sep 25, 2017
| @@ -29,26 +23,36 @@ for realtime notifications when the board changes. | |||
| [fb-overview]: https://console.firebase.google.com/project/_/overview | |||
| [maven]: https://maven.apache.org | |||
|
|
|||
| ## Setup | |||
|
|
|||
| * If you haven't already, Download and initialize the [Cloud SDK](https://cloud.google.com/sdk/) | |||
There was a problem hiding this comment.
Shouldn't this be a Prerequisite?
| ``` | ||
| gcloud init | ||
| ``` | ||
| * If you haven't already, Create an App Engine app within the current Google Cloud Project |
| Download [service account credentials][creds] and set the `GOOGLE_APPLICATION_CREDENTIALS` | ||
| environment variable to its path: | ||
| ``` | ||
| export GOOGLE_APPLICATION_CREDENTIALS=/path/to/your/credentials.json |
There was a problem hiding this comment.
Should we have them set GOOGLE_CLOUD_PROJECT? Look at gcloud config to verify their project?
There was a problem hiding this comment.
given we still ask users to use gcloud init : added a note there that this sets the project.
| servletUnderTest.doPost(mockRequest, mockResponse); | ||
|
|
||
| game = ofy.load().type(Game.class).id(gameKey).safe(); | ||
| assertThat(game.board).isEqualTo(" X "); | ||
| assertEquals(game.board, " X "); |
There was a problem hiding this comment.
Truth might make this cleaner.
There was a problem hiding this comment.
Minimizing test dependencies, so leaving this as-is
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
…3.0 (#862) * chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
…3.0 (#862) * chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
…3.0 (#862) * chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
🤖 I have created a release *beep* *boop* --- ## [3.3.0](googleapis/java-dlp@v3.2.1...v3.3.0) (2022-04-15) ### Features * add DataProfilePubSubMessage supporting pub/sub integration ([#855](googleapis/java-dlp#855)) ([86eeaaa](googleapis/java-dlp@86eeaaa)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([#863](googleapis/java-dlp#863)) ([a0a3164](googleapis/java-dlp@a0a3164)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue in running app locally as reported by customer:
https://cloud.google.com/appengine/docs/deprecations/channel