Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Endpoints] Update/Add samples with new tooling and Guice support for v2 #842

Merged
merged 18 commits into from
Sep 8, 2017
Merged

[Endpoints] Update/Add samples with new tooling and Guice support for v2 #842

merged 18 commits into from
Sep 8, 2017

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Sep 6, 2017

Hi @jabubake,

This PR does the following:

@frankyn frankyn requested a review from jabubake September 6, 2017 23:58
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 6, 2017
lesv
lesv approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do this all the time, but I don't expect anyone to review. This would be good as two separate PR's in the future. Very nice - Thanks.

@frankyn
Copy link
Member Author

frankyn commented Sep 8, 2017

Thanks Les, merging now.

@frankyn frankyn merged commit a874897 into master Sep 8, 2017
@frankyn frankyn deleted the endpoints-update branch September 8, 2017 17:11
minherz pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore(main): release 0.122.23-SNAPSHOT (#842)
6868331 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore(main): release 0.122.23-SNAPSHOT (#842)
5ed258f 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore(main): release 0.122.23-SNAPSHOT (#842)
8510db8 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@charlieyu1996 charlieyu1996 mentioned this pull request Nov 11, 2022
Merged
9 tasks
charlieyu1996 pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
deps: update dependency com.google.protobuf:protobuf-java-util to v3.…
0a0dc88 
…21.4 (#842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@jabubake jabubake Awaiting requested review from jabubake

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guice + endpoints v2 example?
3 participants
@frankyn @lesv @googlebot