Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stackdriver logging samples (JUL, Logback, Client library) #826

Merged
merged 6 commits into from
Aug 25, 2017
Merged

Stackdriver logging samples (JUL, Logback, Client library) #826

merged 6 commits into from
Aug 25, 2017

Conversation

jabubake
Copy link
Contributor

  • Also updated List Logs snippets to use google-cloud-java

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2017
@jabubake jabubake requested a review from lesv August 24, 2017 23:21
lesv
lesv reviewed Aug 24, 2017
View reviewed changes
logging/cloud-client/src/main/java/com/example/logging/QuickstartSample.java
.setLogName(logName)
.setResource(MonitoredResource.newBuilder("global").build())
.build();

// Writes the log entry
// Writes the log entry asynchronously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, do we do anything to improve the odds that logs get written even if the app crashes? Can we? Big try / catch in main?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do offer a logging.flush() but would n't help with the try / catch in main.
I get your point though, so will look into it separately as an issue on google-cloud-java.

lesv
lesv approved these changes Aug 24, 2017
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wish to have a matching CL (before merging) as your removing existing samples.

logging/jul/src/main/java/com/example/logging/jul/Quickstart.java Outdated
@@ -0,0 +1,31 @@
/*
Copyright 2017, Google, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think the "," is nesc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Fixed missing licenses too.

logging/logback/src/main/java/com/example/logging/logback/Quickstart.java Outdated
@@ -0,0 +1,31 @@
/*
Copyright 2017, Google, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

jabubake
jabubake commented Aug 25, 2017
View reviewed changes
Copy link
Contributor Author

@jabubake jabubake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lesv : I've confirmed that the samples I removed are no longer referenced in the docs.

@jabubake jabubake merged commit 219f9ad into master Aug 25, 2017
@jabubake jabubake deleted the stackdriver-logging branch August 25, 2017 17:00
@jabubake jabubake mentioned this pull request Aug 25, 2017
Closed
minherz pushed a commit that referenced this pull request Nov 9, 2022
@release-please
chore(main): release 0.122.20-SNAPSHOT (#826)
687fd13 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore(main): release 0.122.20-SNAPSHOT (#826)
8b67ca4 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
minherz pushed a commit that referenced this pull request Nov 10, 2022
@release-please @minherz
chore(main): release 0.122.20-SNAPSHOT (#826)
f5e1e12 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
charlieyu1996 pushed a commit that referenced this pull request Nov 10, 2022
@gcf-owl-bot
chore(bazel): Update WORKSPACE files for rules_gapic, gax_java, gener…
eb7408f 
…ator_java versions (#826)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
@charlieyu1996 charlieyu1996 mentioned this pull request Nov 10, 2022
Closed
9 tasks
@Sita04 Sita04 mentioned this pull request Nov 11, 2022
Merged
9 tasks
Sita04 pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
deps: update dependency org.seleniumhq.selenium:selenium-java to v4.3…
ee676ec 
….0 (#826)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.seleniumhq.selenium:selenium-java](https://selenium.dev/) ([source](https://togithub.com/SeleniumHQ/selenium)) | `4.2.2` -> `4.3.0` | [![age](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/compatibility-slim/4.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/confidence-slim/4.2.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).
Sita04 pushed a commit that referenced this pull request Nov 15, 2022
@renovate-bot @Sita04
deps: update dependency org.seleniumhq.selenium:selenium-java to v4.3…
5afcde0 
….0 (#826)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.seleniumhq.selenium:selenium-java](https://selenium.dev/) ([source](https://togithub.com/SeleniumHQ/selenium)) | `4.2.2` -> `4.3.0` | [![age](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/compatibility-slim/4.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.seleniumhq.selenium:selenium-java/4.3.0/confidence-slim/4.2.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recaptchaenterprise).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jabubake @lesv @googlebot