Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instructions for Windows and upgrades client library versions. #750

Merged
merged 6 commits into from
Jul 14, 2017
Merged

Adds instructions for Windows and upgrades client library versions. #750

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2f31b73
Adds instructions for Windows and upgrades client library versions.
gguuss Jul 7, 2017
f949ba2
Merge branch 'master' into video-version-bump
gguuss Jul 11, 2017
82a5659
Merge branch 'master' into video-version-bump
gguuss Jul 11, 2017
f92eb66
Upgrades client to 0.20.1 and addresses changes to long running opera…
gguuss Jul 12, 2017
f593da3
Merge branch 'video-version-bump' of https://github.com/googlecloudpl…
gguuss Jul 12, 2017
14400b8
Adds missing dependency until the video library is fixed.
gguuss Jul 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions video/cloud-client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,12 @@ Detect Shots
java -cp target/video-google-cloud-samples-1.0.0-jar-with-dependencies.jar \
com.example.video.Detect shots gs://cloudmleap/video/next/gbikes_dinosaur.mp4
```

From Windows, you may need to supply your classpath diferently, for example:
```
java -cp target\\video-google-cloud-samples-1.0.0-jar-with-dependencies.jar com.example.video.Detect labels gs://demomaker/cat.mp4
```
or
```
java -cp target\\video-google-cloud-samples-1.0.0-jar-with-dependencies.jar com.example.video.Detect labels-file resources/cat.mp4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should n't 'resources/cat.mp4' also be 'resources\cat.mp4' ?
I'm concerned of maintenance / consistency of these comments across our samples : is there a general statement we can make in our samples that paths to local directories are made in Unix style and need to be updated to the backslash for Windows environments ?

Copy link
Contributor Author

@gguuss gguuss Jul 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great point! We're using the PATH module which automatically translates the Unix-style path to a Windows-style file path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the path with the forward slashes there on purpose for consistency but am happy to make the change if you feel it's better with escaped \s.

```
14 changes: 1 addition & 13 deletions video/cloud-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,24 +43,12 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud</artifactId>
<version>0.18.0-alpha</version>
<exclusions>
<exclusion> <!-- exclude an old version of Guava -->
<groupId>com.google.guava</groupId>
<artifactId>guava-jdk5</artifactId>
</exclusion>
</exclusions>
<version>0.20.0-alpha</version>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-video-intelligence</artifactId>
<version>0.20.0-alpha</version>
<exclusions>
<exclusion> <!-- exclude an old version of Guava -->
<groupId>com.google.guava</groupId>
<artifactId>guava-jdk5</artifactId>
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>com.google.auth</groupId>
Expand Down