Adds an Endpoints sample with multiple versions. #627

wmwong · 2017-04-24T21:00:23Z

This is a copy of the existing getting-started sample with extensions to support multiple versions.

The difference in the API between v1 and v2 is the use of "message" vs "msg".

The code sample shows:

Simple input layer that receives API requests from multiple major versions (v1/v2 servlets).
Simple translation to a backend format (v1/v2 translators).
Simple backend processing (uppercasing the message).
Simple translation to the response format (v1/v2 translators).

No integration tests were written (similar to the other Endpoints samples) because this sample doesn't call any services. Instead, it is meant to be a sample that is deployed to GCP.

lesv

PTAL

lesv · 2017-04-24T21:10:51Z

endpoints/multiple-versions/container-engine.yaml

@@ -0,0 +1,56 @@
+# Copyright 2015 Google Inc. All Rights Reserved.


lesv · 2017-04-24T21:11:03Z

endpoints/multiple-versions/openapi-v2.yaml

@@ -0,0 +1,108 @@
+# [START swagger]


Should have a license

lesv · 2017-04-24T21:11:30Z

endpoints/multiple-versions/openapi-v2.yaml

+- "application/json"
+schemes:
+- "https"
+paths:


Some whitespace would make this a bit more readable.

I indented all the lists using https://github.com/OAI/OpenAPI-Specification/tree/master/examples/v2.0/yaml as examples. They seem to indent '-'. Also, if the item is more than one line, the '-' is on its own line.

lesv · 2017-04-24T21:11:53Z

endpoints/multiple-versions/openapi.yaml

@@ -0,0 +1,108 @@
+# [START swagger]


License & vertical whitespace

lesv · 2017-04-24T21:12:11Z

endpoints/multiple-versions/pom.xml

@@ -0,0 +1,83 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


lesv · 2017-04-24T21:15:17Z

endpoints/multiple-versions/src/main/java/com/example/endpoints/EchoV2Servlet.java

@@ -0,0 +1,42 @@
+/**
+ * Copyright 2015 Google Inc. All Rights Reserved.


lesv · 2017-04-24T21:15:34Z

endpoints/multiple-versions/src/main/java/com/example/endpoints/messsage/Message.java

@@ -0,0 +1,34 @@
+/**
+ * Copyright 2015 Google Inc. All Rights Reserved.


lesv · 2017-04-24T21:15:48Z

endpoints/multiple-versions/src/main/java/com/example/endpoints/messsage/MessageTranslator.java

@@ -0,0 +1,26 @@
+/**
+ * Copyright 2015 Google Inc. All Rights Reserved.


Strike ARR.

lesv · 2017-04-24T21:15:55Z

...ints/multiple-versions/src/main/java/com/example/endpoints/messsage/MessageV1Translator.java

@@ -0,0 +1,34 @@
+/**
+ * Copyright 2015 Google Inc. All Rights Reserved.


lesv · 2017-04-24T21:16:04Z

...ints/multiple-versions/src/main/java/com/example/endpoints/messsage/MessageV2Translator.java

@@ -0,0 +1,34 @@
+/**
+ * Copyright 2015 Google Inc. All Rights Reserved.


codecov-io · 2017-04-24T21:26:09Z

Codecov Report

Merging #627 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #627   +/-   ##
=========================================
  Coverage     55.84%   55.84%           
  Complexity      202      202           
=========================================
  Files            74       74           
  Lines          2052     2052           
  Branches        131      131           
=========================================
  Hits           1146     1146           
  Misses          874      874           
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d6fa3...f6f2127. Read the comment docs.

lesv

If there is a clear reason why you aren't using the new Maven plugin, mention it.

lesv · 2017-04-25T17:58:52Z

endpoints/multiple-versions/pom.xml

+    <!-- for hot reload of the web application -->
+    <outputDirectory>${project.build.directory}/${project.build.finalName}/WEB-INF/classes</outputDirectory>
+    <plugins>
+      <plugin>  <!-- TEMPORARY -->


I meant the other one:

<plugins> <plugin> <groupId>com.google.cloud.tools</groupId> <artifactId>appengine-maven-plugin</artifactId> <version>1.3.0</version> </plugin> <plugin> <groupId>org.eclipse.jetty</groupId> <artifactId>jetty-maven-plugin</artifactId> <version>9.4.3.v20170317</version> </plugin> </plugins>

…oogleCloudPlatform/java-docs-samples into add-endpoints-multiple-versions-sample

wmwong · 2017-04-25T18:57:55Z

Removed the old maven plugin. Tested locally and deployed to AppEngine. All working.

lesv · 2017-04-25T20:16:56Z

Argh - I thought I added the DO NOT MERGE tag -- sorry.

wmwong · 2017-04-25T20:25:15Z

I had added the DO NOT MERGE tag at the beginning. Looks like you might have accidentally removed it.

Should be fine I guess.

Adds the same updates in the comments in #627. Also fixes the variables to replace in app.yaml.

… v0.9.10 (#627)

🤖 I have created a release \*beep\* \*boop\* --- ### [0.122.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.122.0...v0.122.1) (2021-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.0.5 ([#625](https://www.github.com/googleapis/java-errorreporting/issues/625)) ([c522d92](https://www.github.com/googleapis/java-errorreporting/commit/c522d9295182360063f0bc8796afe856afbfbc91)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.0.1 ([#627](https://www.github.com/googleapis/java-errorreporting/issues/627)) ([59a854e](https://www.github.com/googleapis/java-errorreporting/commit/59a854eddf390ec6aeec8d951aa3824b1e703b4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…en-plugin to v1.6.10 (#627) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.sonatype.plugins:nexus-staging-maven-plugin](http://www.sonatype.com/) ([source](https://togithub.com/sonatype/nexus-maven-plugins)) | `1.6.9` -> `1.6.10` | [![age](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/compatibility-slim/1.6.9)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.10/confidence-slim/1.6.9)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sonatype/nexus-maven-plugins</summary> ### [`v1.6.10`](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.9...release-1.6.10) [Compare Source](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.9...release-1.6.10) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-servicedirectory).

🤖 I have created a release \*beep\* \*boop\* --- ### [0.122.1](https://www.github.com/googleapis/java-errorreporting/compare/v0.122.0...v0.122.1) (2021-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.0.5 ([#625](https://www.github.com/googleapis/java-errorreporting/issues/625)) ([c522d92](https://www.github.com/googleapis/java-errorreporting/commit/c522d9295182360063f0bc8796afe856afbfbc91)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.0.1 ([#627](https://www.github.com/googleapis/java-errorreporting/issues/627)) ([59a854e](https://www.github.com/googleapis/java-errorreporting/commit/59a854eddf390ec6aeec8d951aa3824b1e703b4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…tion to v0.123.4-beta (#627) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-notification](https://togithub.com/googleapis/java-notification) | `0.123.2-beta` -> `0.123.4-beta` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-notification/0.123.4-beta/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-notification/0.123.4-beta/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-notification/0.123.4-beta/compatibility-slim/0.123.2-beta)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-notification/0.123.4-beta/confidence-slim/0.123.2-beta)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).

…2.0 (#627) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.1.2` -> `24.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.2.0/compatibility-slim/24.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.2.0/confidence-slim/24.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-texttospeech).

Adds an Endpoints sample with multiple versions.

8ba239f

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 24, 2017

wmwong added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 24, 2017

lesv suggested changes Apr 24, 2017

View reviewed changes

wmwong mentioned this pull request Apr 24, 2017

Update the Endpoints getting-started sample #628

Closed

wmwong and others added 2 commits April 25, 2017 10:42

Updates licenses, pom.xml, and whitespacing.

07c58e0

Merge branch 'master' into add-endpoints-multiple-versions-sample

944d5ce

lesv removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 25, 2017

lesv approved these changes Apr 25, 2017

View reviewed changes

wmwong added 2 commits April 25, 2017 11:35

Removes the old maven plugin.

0ab28d1

Merge branch 'add-endpoints-multiple-versions-sample' of github.com:G…

f6f2127

…oogleCloudPlatform/java-docs-samples into add-endpoints-multiple-versions-sample

lesv merged commit 5b63acb into master Apr 25, 2017

lesv deleted the add-endpoints-multiple-versions-sample branch April 25, 2017 20:16

wmwong added a commit that referenced this pull request May 2, 2017

Updates the Endpoints getting-started sample.

f14f8e8

Adds the same updates in the comments in #627. Also fixes the variables to replace in app.yaml.

wmwong mentioned this pull request May 2, 2017

Updates the Endpoints getting-started sample. #642

Merged

dpebot pushed a commit that referenced this pull request May 3, 2017

Updates the Endpoints getting-started sample. (#642)

2d71e88

Adds the same updates in the comments in #627. Also fixes the variables to replace in app.yaml.

averikitsch pushed a commit that referenced this pull request Oct 27, 2022

deps: update dependency org.graalvm.buildtools:native-maven-plugin to…

0b3667f

… v0.9.10 (#627)

averikitsch mentioned this pull request Oct 27, 2022

migrate code from googleapis/java-tasks #7368

Merged

9 tasks

This was referenced Nov 9, 2022

(WIP) samples: migrate code from googleapis/java-servicedirectory #7396

Closed

[WIP] samples: migrate code from googleapis/java-servicedirectory #7397

Closed

bourgeoisor mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-notification #7406

Closed

9 tasks

charlieyu1996 mentioned this pull request Nov 15, 2022

migrate code from googleapis/java-texttospeech #7423

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds an Endpoints sample with multiple versions. #627

Adds an Endpoints sample with multiple versions. #627

wmwong commented Apr 24, 2017

lesv left a comment

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

lesv Apr 24, 2017

wmwong Apr 25, 2017

codecov-io commented Apr 24, 2017 •

edited

Loading

lesv left a comment

lesv Apr 25, 2017

wmwong commented Apr 25, 2017

lesv commented Apr 25, 2017

wmwong commented Apr 25, 2017

		@@ -0,0 +1,56 @@
		# Copyright 2015 Google Inc. All Rights Reserved.

		@@ -0,0 +1,83 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

		@@ -0,0 +1,42 @@
		/**
		* Copyright 2015 Google Inc. All Rights Reserved.

		@@ -0,0 +1,34 @@
		/**
		* Copyright 2015 Google Inc. All Rights Reserved.

		@@ -0,0 +1,26 @@
		/**
		* Copyright 2015 Google Inc. All Rights Reserved.

Adds an Endpoints sample with multiple versions. #627

Adds an Endpoints sample with multiple versions. #627

Conversation

wmwong commented Apr 24, 2017

lesv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Apr 24, 2017 • edited Loading

Codecov Report

lesv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wmwong commented Apr 25, 2017

lesv commented Apr 25, 2017

wmwong commented Apr 25, 2017

codecov-io commented Apr 24, 2017 •

edited

Loading