Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for Endpoints Frameworks v2.0 discovery doc sample #505

Merged
merged 4 commits into from
Feb 8, 2017
Merged

Temporary fix for Endpoints Frameworks v2.0 discovery doc sample #505

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4717d6a
Adding temporary fix for devappserver requires version.
frankyn Feb 8, 2017
cf7155d
Cleaned up build.gradle
frankyn Feb 8, 2017
95281c3
Typo in path to appengine-web.xml
frankyn Feb 8, 2017
532ecf3
Merge branch 'master' into fix-endpoints-discovery
frankyn Feb 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions appengine/endpoints-frameworks-v2/discovery/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@ provided [here][9].

`gradle appengineDeploy`

## Known issues

There's a [bug][13] where `<version>1</version>` is required in the
[appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml) to run
this sample locally. This will become optional in the near future.


[1]: https://cloud.google.com/appengine/docs/java/
[2]: http://java.com/en/
[3]: https://cloud.google.com/appengine/docs/java/endpoints/
Expand All @@ -108,3 +115,4 @@ provided [here][9].
[10]: https://github.com/GoogleCloudPlatform/endpoints-framework-maven-plugin
[11]: https://github.com/GoogleCloudPlatform/endpoints-framework-gradle-plugin
[12]: https://cloud.google.com/endpoints/docs/authenticating-users-frameworks
[13]: https://github.com/cloudendpoints/endpoints-java/issues/43
3 changes: 0 additions & 3 deletions appengine/endpoints-frameworks-v2/discovery/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ buildscript { // Configuration for building
}

repositories { // repositories for Jar's you access in your code
maven {
url 'https://oss.sonatype.org/content/repositories/snapshots' // SNAPSHOT Repository (if needed)
}
mavenCentral()
jcenter()
}
Expand Down
4 changes: 2 additions & 2 deletions appengine/endpoints-frameworks-v2/discovery/src/main/webapp/WEB-INF/appengine-web.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<threadsafe>true</threadsafe>

<threadsafe>true</threadsafe>
<version>1</version>
<system-properties>
<property name="java.util.logging.config.file" value="WEB-INF/logging.properties"/>
</system-properties>
Expand Down