Add NL quickstart sample. Fix some other quickstarts. #438

jmdobry · 2016-12-07T21:00:58Z

No description provided.

codecov-io · 2016-12-07T21:19:53Z

Current coverage is 49.58% (diff: 100%)

Merging #438 into master will not change coverage

@@             master       #438   diff @@
==========================================
  Files            82         82          
  Lines          2650       2650          
  Methods           0          0          
  Messages          0          0          
  Branches        195        195          
==========================================
  Hits           1314       1314          
  Misses         1293       1293          
  Partials         43         43

Powered by Codecov. Last update d0d4165...136634a

jerjou · 2016-12-07T21:07:46Z

bigquery/cloud-client/src/main/java/com/example/bigquery/QuickstartSample.java

@@ -41,4 +41,3 @@ public static void main(String... args) throws Exception {
    System.out.printf("Dataset %s created.%n", dataset.getDatasetId().getDataset());
  }
 }
-// [END bigquery_quickstart]


Er? What's with this? What about the start tag?

jerjou · 2016-12-07T21:10:36Z

language/cloud-client/README.md

+[Google Cloud Natural Language API][language] provides natural language
+understanding technologies to developers, including sentiment analysis, entity
+recognition, and syntax analysis. This API is part of the larger Cloud Machine
+Learning API.


-> ...part of the larger collection of Cloud Machine Learning APIs

jerjou · 2016-12-07T21:11:59Z

language/cloud-client/README.md

+	    -DpropertyName=propertyValue \
+		-Dexec.args="any arguments to the app"
+
+### Analyize a string for sentiment (using the quickstart sample)


jerjou · 2016-12-07T21:13:55Z

language/cloud-client/README.md

+
+	mvn exec:java -Dexec.mainClass=com.example.language.ClassName \
+	    -DpropertyName=propertyValue \
+		-Dexec.args="any arguments to the app"


I'd do:

-Dexec.args="arg1 'arg 2' arg3"

to make clear that spaces in a single arg have to be quoted.

jerjou · 2016-12-07T21:20:54Z

language/cloud-client/src/main/java/com/example/language/QuickstartSample.java

+
+// [START language_quickstart]
+// Imports the Google Cloud client library
+import com.google.cloud.language.spi.v1.LanguageServiceClient;


Do you know why this is in a different package than the rest?

Nope, I'm copying from https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/language/analysis/src/main/java/com/google/cloud/language/samples/Analyze.java

jmdobry · 2016-12-07T22:02:14Z

Addressed comments.

jerjou · 2016-12-07T22:24:28Z

datastore/cloud-client/src/main/java/com/example/datastore/QuickstartSample.java

@@ -46,4 +46,3 @@ public static void main(String... args) throws Exception {
    System.out.printf("Saved %s: %s%n", task.getKey().getName(), task.getString("description"));
  }
 }
-// [END datastore_quickstart]


You've got a bunch more of these deletions running around - I assume they're all unintentional?

All fixed. You are right, some of them were mistakes. Some of the deletions are legit though.

Oh I see. Cool

jerjou

LGTM

jerjou · 2016-12-07T22:41:34Z

@lesv FYI

jmdobry · 2016-12-08T00:21:01Z

Can be merged?

lesv

LGTM

🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…11.2 (#438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.11.1` -> `2.11.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/compatibility-slim/2.11.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/confidence-slim/2.11.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.11.2`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2112-httpsgithubcomgoogleapisjava-bigquerycomparev2111v2112-2022-05-18) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.11.1...v2.11.2) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).

…4.0 (#438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `16.3.0` -> `16.4.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/16.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/16.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/16.4.0/compatibility-slim/16.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/16.4.0/confidence-slim/16.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc).

…1.0 (#438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `18.0.0` -> `18.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.1.0/compatibility-slim/18.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.1.0/confidence-slim/18.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-recommender).

…438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `17.0.0` -> `18.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.0.0/compatibility-slim/17.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/18.0.0/confidence-slim/17.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datacatalog).

…11.2 (#438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.11.1` -> `2.11.2` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/compatibility-slim/2.11.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-bigquery/2.11.2/confidence-slim/2.11.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.11.2`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#2112-httpsgithubcomgoogleapisjava-bigquerycomparev2111v2112-2022-05-18) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.11.1...v2.11.2) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).

…438) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `16.4.0` -> `17.0.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/17.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/17.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/17.0.0/compatibility-slim/16.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/17.0.0/confidence-slim/16.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).

jmdobry assigned jerjou Dec 7, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2016

jerjou reviewed Dec 7, 2016

View reviewed changes

jmdobry force-pushed the quickstarts branch from f7e2ece to 6a262f6 Compare December 7, 2016 22:01

jerjou reviewed Dec 7, 2016

View reviewed changes

Add NL quickstart sample. Fix some other quickstarts.

136634a

jmdobry force-pushed the quickstarts branch from 6a262f6 to 136634a Compare December 7, 2016 22:26

jerjou approved these changes Dec 7, 2016

View reviewed changes

lesv reviewed Dec 8, 2016

View reviewed changes

jmdobry merged commit c375d21 into master Dec 8, 2016

lesv deleted the quickstarts branch December 8, 2016 17:30

Shabirmean mentioned this pull request Nov 10, 2022

samples: migrate code from googleapis/java-retail #7403

Merged

9 tasks

bourgeoisor mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-dataproc #7407

Merged

9 tasks

Shabirmean mentioned this pull request Nov 11, 2022

samples: migrate code from googleapis/java-recommender #7410

Closed

9 tasks

charlieyu1996 mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-datacatalog #7412

Merged

9 tasks

Shabirmean pushed a commit that referenced this pull request Nov 17, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

467fc11

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-language #7436

Merged

9 tasks

Shabirmean pushed a commit that referenced this pull request Nov 17, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

13c25fc

Shabirmean pushed a commit that referenced this pull request Nov 17, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

b3ad297

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-translate #7443

Closed

9 tasks

Shabirmean pushed a commit that referenced this pull request Nov 18, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

749cba3

Shabirmean mentioned this pull request Nov 18, 2022

samples: migrate code from googleapis/java-translate #7445

Merged

9 tasks

Shabirmean pushed a commit that referenced this pull request Nov 18, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

a4f5036

anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022

samples: Add NL quickstart sample. Fix some other quickstarts. (#438)

39098ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NL quickstart sample. Fix some other quickstarts. #438

Add NL quickstart sample. Fix some other quickstarts. #438

jmdobry commented Dec 7, 2016

codecov-io commented Dec 7, 2016 •

edited

Loading

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jmdobry commented Dec 7, 2016

jerjou Dec 7, 2016

jmdobry Dec 7, 2016

jerjou Dec 7, 2016

jerjou left a comment

jerjou commented Dec 7, 2016

jmdobry commented Dec 8, 2016

lesv left a comment

Add NL quickstart sample. Fix some other quickstarts. #438

Add NL quickstart sample. Fix some other quickstarts. #438

Conversation

jmdobry commented Dec 7, 2016

codecov-io commented Dec 7, 2016 • edited Loading

Current coverage is 49.58% (diff: 100%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmdobry commented Dec 7, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jerjou left a comment

Choose a reason for hiding this comment

jerjou commented Dec 7, 2016

jmdobry commented Dec 8, 2016

lesv left a comment

Choose a reason for hiding this comment

codecov-io commented Dec 7, 2016 •

edited

Loading