Add shellcheck to Travis tests and fix existing shell lint errors. #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
apt-get install failed. :( |
|
Yep. Looks like I need to add the repo info. Updating now. https://github.com/koalaman/shellcheck/wiki/TravisCI |
tswast
force-pushed
the
tswast-shellcheck
branch
from
9b87a8b to
a7d7fd4
Compare
|
LGTM - once Travis passes it. |
Current coverage is 44.59%@@ master #273 diff @@
==========================================
Files 78 78
Lines 2267 2267
Methods 0 0
Messages 0 0
Branches 154 154
==========================================
Hits 1011 1011
Misses 1225 1225
Partials 31 31
|
anguillanneuf
pushed a commit
that referenced
this pull request
Oct 24, 2022
…nslation to v0.3.2 (#273) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-mediatranslation](https://togithub.com/googleapis/java-mediatranslation) | `0.3.1` -> `0.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-mediatranslation</summary> ### [`v0.3.2`](https://togithub.com/googleapis/java-mediatranslation/blob/master/CHANGELOG.md#​032-httpswwwgithubcomgoogleapisjava-mediatranslationcomparev031v032-2021-04-23) [Compare Source](https://togithub.com/googleapis/java-mediatranslation/compare/v0.3.1...v0.3.2) </details> --- ### Configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-mediatranslation).
9 tasks
averikitsch
pushed a commit
that referenced
this pull request
Nov 4, 2022
…nslation to v0.3.2 (#273) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-mediatranslation](https://togithub.com/googleapis/java-mediatranslation) | `0.3.1` -> `0.3.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-mediatranslation</summary> ### [`v0.3.2`](https://togithub.com/googleapis/java-mediatranslation/blob/master/CHANGELOG.md#​032-httpswwwgithubcomgoogleapisjava-mediatranslationcomparev031v032-2021-04-23) [Compare Source](https://togithub.com/googleapis/java-mediatranslation/compare/v0.3.1...v0.3.2) </details> --- ### Configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-mediatranslation).
minherz
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
minherz
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 11, 2022
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 11, 2022
](https://renovatebot.com){kind=link}
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…-ai to v0.3.5 (#273) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | patch | `0.3.3` -> `0.3.5` | --- ### Release Notes <details> <summary>googleapis/java-document-ai</summary> ### [`v0.3.5`](https://togithub.com/googleapis/java-document-ai/blob/master/CHANGELOG.md#​035-httpswwwgithubcomgoogleapisjava-document-aicomparev034v035-2020-11-12) [Compare Source](https://togithub.com/googleapis/java-document-ai/compare/v0.3.3...v0.3.5) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…-ai to v0.3.5 (#273) [](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | patch | `0.3.3` -> `0.3.5` | --- ### Release Notes <details> <summary>googleapis/java-document-ai</summary> ### [`v0.3.5`](https://togithub.com/googleapis/java-document-ai/blob/master/CHANGELOG.md#​035-httpswwwgithubcomgoogleapisjava-document-aicomparev034v035-2020-11-12) [Compare Source](https://togithub.com/googleapis/java-document-ai/compare/v0.3.3...v0.3.5) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lesv PTAL.