Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving code from TasksQueue Push #205

Closed
wants to merge 4 commits into from

Conversation

Annie29
Copy link
Contributor

@Annie29 Annie29 commented Apr 27, 2016

@tswast, @lesv
Somehow this also includes the changes from requests, which I thought I'd added in #179 . (Could this be because I created the branch for tasks before merging the requests changes?)

I'll need to change the pom.xml file to add requests as well, it seems.

@lesv
Copy link
Contributor

lesv commented Apr 27, 2016

You have conflicts that need to be resolved, and you are pushing from a fork, which means that our testing doesn't run. If you could push from a branch it would be helpful.


$ mvn appengine:update -Dappengine.appId=YOUR-PROJECT-ID -Dappengine.version=SOME-VERSION

## Setup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part appears to be redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, @lesv, now that I see the whole file, I'm just echoing the form @tswast uses.

  • Running locally (obvious)
  • Deploying (obvious, but this is the form used where the user specifies the project id and version on the command line
  • Setup, which is deploying, but putting the parameters in a config uses.

@lesv
Copy link
Contributor

lesv commented Apr 27, 2016

A few things to do.

@Annie29
Copy link
Contributor Author

Annie29 commented Apr 27, 2016

So, I think I've got branches working, so replace this pull request with number 209.

@Annie29 Annie29 closed this Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants