Add Data Catalog createEntry quickstart samples and tests. #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tswast
reviewed
Nov 13, 2019
...catalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntryQuickStart.java
Outdated
Show resolved
Hide resolved
tswast
reviewed
Nov 27, 2019
datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java
Outdated
Show resolved
Hide resolved
datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateEntryGroup.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Store names for clean up on teardown | ||
| String expectedEntryGroupName = | ||
| EntryGroupName.of(PROJECT_ID, LOCATION, entryGroupId).toString(); |
There was a problem hiding this comment.
FYI: I think these helpers are being deprecated. At least, they were deprecated in Python (googleapis/gapic-generator#3012) and the same reasoning applies to the Java generator (it's not possible with new proto annotations for configuring the generator).
There was a problem hiding this comment.
Do you know the recommended way?
I see two alternatives...
- Use EntryGroupName.Builder....setProject(project).setLocation(location).setEntryGroup(entryGroup).build()
- Build the string manually
Thanks
There was a problem hiding this comment.
At least in Python (2) is recommended, as the resource builders are going away there. I haven't seen any discussion about it outside of Python, though.
I don't know why, as the same configuration changes affect all languages.
There was a problem hiding this comment.
I see, it makes sense going that way if this configuration will affect all languages...
@kurtisvg Could you point me the recommended way in Java ?
There was a problem hiding this comment.
AFAIK, they aren't going away for Java. They are generally preferred to manually formatting the string.
There was a problem hiding this comment.
@tswast WDYT can we keep the helpers?
There was a problem hiding this comment.
I have doubts that they will actually stay in Java, based on my conversations with Luke on the ACtools team. I'll check with him if the resource helper deprecation is supposed to affect more than just Python.
There was a problem hiding this comment.
Sure, will wait for your confirmation.
There was a problem hiding this comment.
You can proceed with using the resource builders. I misunderstood the reasoning for removal in Python.
There was a problem hiding this comment.
so AFAIK the PR is ready to be merged, @tswast are you able to review it and merge if everything is ok?
tswast
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tswast
approved these changes
Dec 4, 2019
|
I just added the label to run our CI. Once that passes, I think this is OK to merge. |
|
Test failures: |
tswast
reviewed
Dec 4, 2019
| .setDisplayName("My Fileset") | ||
| .setDescription("This fileset consists of ....") | ||
| .setGcsFilesetSpec( | ||
| GcsFilesetSpec.newBuilder().addFilePatterns("gs://my_bucket/*").build()) |
There was a problem hiding this comment.
You might want to use a real bucket here, such as gs://cloud-samples-data
There was a problem hiding this comment.
according to the docs, underscore should be accepted, I filled a bug to check this, but using a real bucket is better, so made the change, thanks.
|
ping @tswast |
tswast
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
9 tasks
charlieyu1996
pushed a commit
that referenced
this pull request
Nov 11, 2022
…1731) * ADD sample for create fileset entry quickstart * RAN google java format * CHANGE exception comment * FIX lint issues * Split quickstart into a new folder * Rename files since class name will appear on samples * Ran java formatter * revert region tags change * remove extra space * change to real bucket name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add samples for Data Catalog create_entry method, released on 0.28.0-alpha google-cloud-datacatalog version.
Since we already have samples for createEntry and createEntryGroup, I would like to submit this PR as an integrated version, which would be used here:
https://cloud.google.com/data-catalog/docs/how-to/filesets#data-catalog-fileset-java