Add Data Catalog createEntry samples and tests. #1638

mesmacosta · 2019-10-22T21:02:18Z

I would like to add samples for Data Catalog create_entry method, released on 0.28.0-alpha google-cloud-datacatalog version.

kurtisvg · 2019-10-23T18:54:33Z

I would like to add samples for Data Catalog create_entry method, released on 0.28.0-alpha google-cloud-datacatalog version.

Are these samples being authored with the intent to include them as part of our docs somewhere? or are you just writing them because you thought the current set of samples is missing this functionality?

mesmacosta · 2019-10-23T19:14:21Z

Hi @kurtisvg,

yes, they are being authored with the intent to include them as part of google docs.

And also the current set of samples is missing this functionality.

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

kurtisvg · 2019-10-23T19:01:20Z

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

+      try {
+        dataCatalogClient.deleteEntry(
+                EntryName.of(projectId, location, entryGroupId, entryId).toString());
+      } catch (Exception e) {


You shouldn't catch Exception - you should catch the specific error being thrown and show the user how to handle it correctly.

Removed, will add new PRs for delete methods.

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

kurtisvg · 2019-10-23T19:02:31Z

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

+      // Delete any pre-existing Entry Group with the same name
+      // that will be used in step 2.
+      try {
+        dataCatalogClient.deleteEntryGroup(


Same as comments above.

Removed, will add new PRs for delete methods.

kurtisvg · 2019-10-23T19:08:31Z

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

+      System.out.printf("\nEntry created with name: %s\n", entryResponse.getName());
+
+
+    } catch (Exception e) {


This Exception is too broad as well.

Changed, also now explaining what could cause the exceptions.

kurtisvg · 2019-10-23T19:09:39Z

datacatalog/cloud-client/src/test/java/com/example/datacatalog/CreateFilesetEntryTests.java

+
+  private static String PROJECT_ID = System.getenv().get("GOOGLE_CLOUD_PROJECT");
+  private static String LOCATION = "us-central1";
+  private static String ENTRY_GROUP_ID = "fileset_entry_group";


these should probably use a randomly generated UUID.

Changed, using only the first 8 chars from UUID, since hyphens are not supported on those IDs.

kurtisvg · 2019-10-23T19:16:42Z

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

+      Entry entry = Entry.newBuilder()
+              .setDisplayName("My Fileset")
+              .setDescription("This fileset consists of ....")
+              .setGcsFilesetSpec(GcsFilesetSpec.newBuilder().addFilePatterns("gs://my_bucket/*")


Generally we try to prioritize splitting between different syntactic levels, and remain consistent:

.setGcsFilesetSpec( GcsFilesetSpec.newBuilder().addFilePatterns("gs://my_bucket/*").build())

Or, if the line is too long:

.setGcsFilesetSpec( GcsFilesetSpec.newBuilder() .addFilePatterns("gs://my_bucket/*") .build())

You can use google-java-format to format the entire file at once.

Ran google-java-format, could you check?

…smacosta/java-docs-samples into task/add-create-fileset-entry

datacatalog/cloud-client/src/main/java/com/example/datacatalog/CreateFilesetEntry.java

kurtisvg · 2019-10-25T17:29:41Z

datacatalog/cloud-client/src/test/java/com/example/datacatalog/CreateEntryGroupTests.java

+
+/** Integration (system) tests for {@link CreateEntryGroup}. */
+@RunWith(JUnit4.class)
+@SuppressWarnings("checkstyle:abbreviationaswordinname")


Can you remove this line? We should try to avoid suppression style checks.

datacatalog/cloud-client/src/test/java/com/example/datacatalog/CreateEntryGroupTests.java

datacatalog/cloud-client/src/test/java/com/example/datacatalog/CreateFilesetEntryTests.java

kurtisvg

LGTM once tests pass

kurtisvg · 2019-10-26T13:33:20Z

Hi @mesmacosta,

This already has my approval. Do you need me to merge it for you?

mesmacosta · 2019-10-26T15:09:40Z

Yes @kurtisvg, can you do that?

* Add Data Catalog createEntry samples and tests * Change second column name * Code review changes * Change region tag for the correct one * Removed tag from region tag since this sample does not tag the entry * ADD method overload to show parameter values examples * Code review changes * Code review changes * Code review and checkstyle changes * Clean up in a safer order

Add Data Catalog createEntry samples and tests

a9b5c7e

mesmacosta requested a review from a team October 22, 2019 21:02

blunderbuss-gcf bot assigned kurtisvg Oct 22, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019

Change second column name

3842dd6

kurtisvg suggested changes Oct 23, 2019

View reviewed changes

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 23, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 23, 2019

mesmacosta and others added 2 commits October 23, 2019 17:09

Code review changes

8b12149

Merge branch 'master' into task/add-create-fileset-entry

7ad0bc8

mesmacosta requested a review from kurtisvg October 23, 2019 20:15

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 23, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 23, 2019

mesmacosta added 3 commits October 23, 2019 18:04

Change region tag for the correct one

daf17bd

Merge branch 'task/add-create-fileset-entry' of https://github.com/me…

dc6daea

…smacosta/java-docs-samples into task/add-create-fileset-entry

Removed tag from region tag since this sample does not tag the entry

6f7d709

kurtisvg suggested changes Oct 23, 2019

View reviewed changes

mesmacosta added 2 commits October 23, 2019 18:57

ADD method overload to show parameter values examples

804612d

Code review changes

6cb3466

mesmacosta requested a review from kurtisvg October 24, 2019 19:40

mesmacosta added 2 commits October 24, 2019 16:49

Merge branch 'master' into task/add-create-fileset-entry

69fb80c

Merge branch 'master' into task/add-create-fileset-entry

412ad13

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kurtisvg suggested changes Oct 25, 2019

View reviewed changes

Code review changes

1cb15ce

mesmacosta requested a review from kurtisvg October 25, 2019 18:27

Merge branch 'master' into task/add-create-fileset-entry

672343b

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kurtisvg suggested changes Oct 25, 2019

View reviewed changes

datacatalog/cloud-client/src/test/java/com/example/datacatalog/CreateFilesetEntryTests.java Outdated Show resolved Hide resolved

Code review and checkstyle changes

8df1a03

mesmacosta requested a review from kurtisvg October 25, 2019 21:46

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kurtisvg approved these changes Oct 25, 2019

View reviewed changes

Clean up in a safer order

0b12da2

kurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019

mesmacosta requested a review from kurtisvg October 26, 2019 12:32

kurtisvg merged commit ce81ede into GoogleCloudPlatform:master Oct 26, 2019

mesmacosta deleted the task/add-create-fileset-entry branch October 28, 2019 13:00

charlieyu1996 mentioned this pull request Nov 11, 2022

migrate code from googleapis/java-datacatalog #7412

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Data Catalog createEntry samples and tests. #1638

Add Data Catalog createEntry samples and tests. #1638

mesmacosta commented Oct 22, 2019

kurtisvg commented Oct 23, 2019

mesmacosta commented Oct 23, 2019

kurtisvg Oct 23, 2019

mesmacosta Oct 23, 2019

kurtisvg Oct 23, 2019

mesmacosta Oct 23, 2019

kurtisvg Oct 23, 2019

mesmacosta Oct 23, 2019

kurtisvg Oct 23, 2019

mesmacosta Oct 23, 2019

kurtisvg Oct 23, 2019

mesmacosta Oct 23, 2019

kurtisvg Oct 25, 2019

mesmacosta Oct 25, 2019

kurtisvg left a comment

kurtisvg commented Oct 26, 2019

mesmacosta commented Oct 26, 2019

		System.out.printf("\nEntry created with name: %s\n", entryResponse.getName());


		} catch (Exception e) {

Add Data Catalog createEntry samples and tests. #1638

Add Data Catalog createEntry samples and tests. #1638

Conversation

mesmacosta commented Oct 22, 2019

kurtisvg commented Oct 23, 2019

mesmacosta commented Oct 23, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kurtisvg left a comment

Choose a reason for hiding this comment

kurtisvg commented Oct 26, 2019

mesmacosta commented Oct 26, 2019