Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests: #1599

Merged
merged 5 commits into from
Oct 25, 2019
Merged

Fix failing tests: #1599

merged 5 commits into from
Oct 25, 2019

Conversation

nnegrey
Copy link
Contributor

@nnegrey nnegrey commented Oct 3, 2019

Update samples to use try for clients and update model IDs due to API backend changes

@nnegrey nnegrey requested a review from a team October 3, 2019 15:57
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2019
@nnegrey
Copy link
Contributor Author

nnegrey commented Oct 7, 2019

Looking at the tests.
Because we have to cut the UUID short due to automl word limit, going to try to fix that a bit more, but also noticing things aren't getting deleted like they should, which is why there is a model id overlap.

@nnegrey nnegrey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@nnegrey nnegrey merged commit c5aedde into master Oct 25, 2019
@nnegrey nnegrey deleted the language-automl-fix branch October 25, 2019 19:39
bradmiro pushed a commit that referenced this pull request Dec 2, 2019
@nnegrey @bradmiro
Fix failing tests: (#1599)
799368d 
* Update samples to use try for clients and update model IDs due to API backend changes

* Update to latest library to fix timeout
@nnegrey nnegrey mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzlier-gcp dzlier-gcp dzlier-gcp approved these changes

Assignees

@dzlier-gcp dzlier-gcp

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnegrey @dzlier-gcp @googlebot @kokoro-team