Add samples for Data Catalog lookupEntry #1416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
googlebot
added
the
cla: yes
|
PTAL the new sample format in CONTRIBUTING.md @kurtisvg for additional info. |
|
It's highly suggested to use the updated sample format, which has guidelines here. This is to avoid having to update the samples again in the new future. |
|
My quick glance was that I didn't see the comments on the parameters being passed, so I didn't scan the rest of the sample. https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md And take a look here: https://github.com/GoogleCloudPlatform/java-docs-samples/tree/master/dlp/src/main/java/dlp/snippets |
|
Just pushed a new version with several changes. I believe it's more consistent with the recommended standards now. |
kurtisvg
added
the
kokoro:run
kokoro-team
removed
kokoro:run
kurtisvg
suggested changes
May 14, 2019
datacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java
Show resolved
Hide resolved
datacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java
Outdated
Show resolved
Hide resolved
datacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java
Outdated
Show resolved
Hide resolved
datacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java
Outdated
Show resolved
Hide resolved
...talog/cloud-client/src/test/java/com/example/datacatalog/LookupEntryBigQueryDatasetTest.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Kurtis Van Gent <[email protected]>
kurtisvg
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
kurtisvg
added
kokoro:run
kurtisvg
suggested changes
May 14, 2019
datacatalog/cloud-client/src/main/java/com/example/datacatalog/QuickStart.java
Outdated
Show resolved
Hide resolved
kurtisvg
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
kurtisvg
approved these changes
May 14, 2019
kurtisvg
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
|
fixes #1410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding samples to Data Catalog lookup_entry, according to #1410