Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datalabeling beta samples #1365

Merged

Conversation

nirupa-kumar
Copy link
Contributor

Stepping in for @nnegrey

@nirupa-kumar nirupa-kumar requested a review from a team April 3, 2019 21:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2019
@nirupa-kumar
Copy link
Contributor Author

@kurtisvg
Please review. These samples have been written by @nnegrey and previously reviewed by you. Please let me know if it needs any further changes.

@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@nirupa-kumar nirupa-kumar added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 3, 2019
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be commenting out tests to get samples merged - the tests are supposed to be there to verify the samples are functioning correctly.

@nirupa-kumar
Copy link
Contributor Author

@kurtisvg thanks. working with product team now to figure out what could be going on here.

@nirupa-kumar
Copy link
Contributor Author

@kurtisvg Please review. Fixed the tests.

Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small nits, but LGTM

@nirupa-kumar nirupa-kumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2019
@nirupa-kumar nirupa-kumar merged commit 978f398 into GoogleCloudPlatform:master Apr 4, 2019
ivanmkc pushed a commit that referenced this pull request Nov 3, 2022
* Datalabeling beta samples

* Fixing tests

* Fixing tests

* Ignoring tests for now due to time duration.

* Ignoring tests for now due to time duration.

* Ignoring tests for now due to time duration.

* debugging

* debugging
averikitsch pushed a commit that referenced this pull request Nov 9, 2022
* Datalabeling beta samples

* Fixing tests

* Fixing tests

* Ignoring tests for now due to time duration.

* Ignoring tests for now due to time duration.

* Ignoring tests for now due to time duration.

* debugging

* debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants