-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datalabeling beta samples #1365
Datalabeling beta samples #1365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be commenting out tests to get samples merged - the tests are supposed to be there to verify the samples are functioning correctly.
@kurtisvg thanks. working with product team now to figure out what could be going on here. |
@kurtisvg Please review. Fixed the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small nits, but LGTM
datalabeling/beta/cloud-client/src/main/java/com/example/datalabeling/LabelImage.java
Show resolved
Hide resolved
datalabeling/beta/cloud-client/src/main/java/com/example/datalabeling/LabelText.java
Outdated
Show resolved
Hide resolved
* Datalabeling beta samples * Fixing tests * Fixing tests * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * debugging * debugging
* Datalabeling beta samples * Fixing tests * Fixing tests * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * debugging * debugging
Stepping in for @nnegrey