Update to use shared data bucket for import test in Product Search #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nirupa-kumar
commented
Dec 19, 2018
•
nirupa-kumar
commented
- Fixed the importProductSets test to use the csv file in the shared bucket.
- Added note for the pre-created product set requirement for Similar Product Search
googlebot
added
the
cla: yes
|
@nnegrey |
dzlier-gcp
previously approved these changes
Jan 10, 2019
dzlier-gcp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
I just updated this to match master branch, and the tests now fail consistently. Please review the test logs. |
|
@nirupa-kumar @nnegrey PTAL at the tests |
|
working on trying to fix the flakiness. |
|
@nnegrey Is this PR still needed or can we close it out? |
|
Oh gosh, um I should probably pick this up. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.