Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud SQL Postgres connectivity sample for servlets. #1255

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Add Cloud SQL Postgres connectivity sample for servlets. #1255

merged 2 commits into from
Nov 8, 2018

Conversation

kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Nov 7, 2018

Same as #1231, but for PostgreSQL.

Corrects some of the region tags to be MySQL-specific (these are pretty much the same for Java, but vary in some languages so separate region tags are needed).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 7, 2018
@kurtisvg kurtisvg requested a review from lesv November 7, 2018 22:54
lesv
lesv approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I hate that you have to specify things twice. That never goes well for me.
    (The alternative however is way too convoluted).
  2. If I haven't mentioned it before, voting / counting apps can be problematic at times.

That said it all looks very nice.

@kurtisvg kurtisvg merged commit 3d6f7be into master Nov 8, 2018
@kurtisvg kurtisvg deleted the postgres-conn branch November 8, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurtisvg @lesv @googlebot