[DO_NOT_MERGE] Microphone streaming with a 1 minute duration. #1185

nirupa-kumar · 2018-08-16T22:40:19Z

@nnegrey Please review

nirupa-kumar · 2018-08-16T22:51:41Z

fixing the styling issues.

nnegrey

Mostly NITs and style stuff.

nnegrey · 2018-08-16T22:45:33Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+   * @throws Exception
+   */
+  public static void streamingMicRecognize() throws Exception {
+    AudioFormat audioFormat = new AudioFormat(16000, 16, 1, true, false);


Can you add a comment for what the numbers mean?
I think it's like:
// SampleRateHertz: 16000
...

nnegrey · 2018-08-16T23:00:05Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+
+  /**
+   * Performs microphone streaming speech recognition with a duration of 1 minute.
+   *


Delete empty line.

nnegrey · 2018-08-16T23:00:23Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

@@ -704,6 +717,99 @@ public void onCompleted() {
  }
  // [END speech_stream_recognize_punctuation]

+  // [START speech_streaming_mic_recognize]
+


Let's remove the space, so that when importing to the docs, there isn't a blank line at the top. :)

nnegrey · 2018-08-16T23:00:36Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+    }
+    responseObserver.onComplete();
+  }
+


Remove empty line

nnegrey · 2018-08-16T23:07:33Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+   *
+   */
+  public static void streamingMicRecognize() throws Exception {
+    AudioFormat audioFormat = new AudioFormat(16000, 16, 1, true, false);


Let's add a comment about what these values mean:

I think they're like
// SampleRateHertz: 16000

nnegrey · 2018-08-16T23:08:46Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+   */
+  public static void streamingMicRecognize() throws Exception {
+    AudioFormat audioFormat = new AudioFormat(16000, 16, 1, true, false);
+    DataLine.Info targetInfo = new Info(TargetDataLine.class, audioFormat);


Add comment along the lines of: // Get system information about microphone ?

nnegrey · 2018-08-16T23:14:43Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+      ClientStream<StreamingRecognizeRequest> clientStream =
+          client.streamingRecognizeCallable().splitCall(responseObserver);
+
+      RecognitionConfig recConfig =


Let's use the full names, since there are several config things being passed around to add clarity:
recognitionConfig

nnegrey · 2018-08-16T23:15:13Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              .setLanguageCode("en-US")
+              .setSampleRateHertz(16000)
+              .build();
+      StreamingRecognitionConfig config =


Same thing for this variable: streamingRecognitionConfig since there are multiple configs

nnegrey · 2018-08-16T23:18:01Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+  public static void streamingMicRecognize() throws Exception {
+    AudioFormat audioFormat = new AudioFormat(16000, 16, 1, true, false);
+    DataLine.Info targetInfo = new Info(TargetDataLine.class, audioFormat);
+    TargetDataLine targetDataLine;


Is it possible to move the declaration of this variable to when it is instantiated? on line 782. Not sure if there is something with how mic streaming is set up.

nnegrey · 2018-08-16T23:18:55Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+
+      clientStream.send(request);
+
+      // Get the target data line


Short description of what a Target Data Line is. Is is the data from the microphone?

nirupa-kumar · 2018-08-17T18:19:39Z

@nnegrey
Thanks Noah! Fixed all the review comments. Please let me know if there is anything else.

nnegrey

Tiny few more nit things. :)

nnegrey · 2018-08-17T18:24:21Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+          new Info(
+              TargetDataLine.class,
+              audioFormat); // Set the system information to read from the microphone audio stream
+      TargetDataLine targetDataLine;


Delete this line (see below comment)

nnegrey · 2018-08-17T18:24:38Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+        System.exit(0);
+      }
+      //Target data line captures the audio stream the microphone produces.
+      targetDataLine = (TargetDataLine) AudioSystem.getLine(targetInfo);


TargetDataLine targetDataLine = ...

nnegrey · 2018-08-17T18:25:31Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+              TargetDataLine.class,
+              audioFormat); // Set the system information to read from the microphone audio stream
+      TargetDataLine targetDataLine;
+      int durationMillSec = 60 * 1000; // 60 seconds


Delete this line

nnegrey · 2018-08-17T18:25:59Z

speech/cloud-client/src/main/java/com/example/speech/Recognize.java

+        long estimatedTime = System.currentTimeMillis() - startTime;
+        byte[] data = new byte[6400];
+        audio.read(data);
+        if (estimatedTime > durationMillSec) {


if (estimatedTime > 60000) { // 60 seconds

#1185) * Microphone streaming with a 1 minute duration. * Fixed audit issues. * Fixing issues after review. * Fixing review issues.

### Migrating samples from [googleapis/java-speech](https://togithub.com/googleapis/java-speech/tree/main/samples) into [java-docs-samples/speech](https://togithub.com/GoogleCloudPlatform/java-docs-samples) --- - samples: Speech GA - library update (#1212) - samples: Due to API backend changes, update the samples to match (#1595) - fix: update retry configs, adds generated samples (#26) - build: move clirr to separate check (#30) - feat: add speaker_tag to WordInfo (#40) - chore: update common templates, regenerate tests - samples: Fix flaky speech test for speaker diarization (#1829) - chore(regen): update license year for generated files (#82) - chore(regen): regenerate with updated year - samples: move generated samples to generated directory (#105) - chore: update common templates - samples: fix: flaky tests in speech (#2286) - samples: speech: move samples out of branch (#2324) - samples: scaffold pom.xml files (#118) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.3.0 (#122) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.13 (#126) - samples: update shared config (#2443) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.14 (#130) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.0 (#131) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.15 (#133) - chore(deps): update dependency com.google.cloud:libraries-bom to v4.4.1 (#134) - chore(deps): update dependency com.google.cloud:libraries-bom to v5 (#144) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.16 (#149) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.17 (#153) - chore: fix samples snippets and update name in repo-metadata (#155) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.2.0 (#160) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.3.0 (#167) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.5.0 (#177) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.18 (#200) - chore(deps): update dependency com.google.cloud:libraries-bom to v5.7.0 (#199) - chore(deps): update dependency com.google.cloud:libraries-bom to v6 (#210) - chore(deps): update dependency com.google.cloud:libraries-bom to v7 (#214) - chore(deps): update dependency com.google.cloud:libraries-bom to v7.0.1 (#222) - chore(deps): update dependency com.google.cloud:libraries-bom to v8 (#227) - chore(deps): update dependency com.google.cloud:libraries-bom to v8.1.0 (#237) - samples: Add Speech API quickstart sample. (#497) - samples: Adds sync / async examples for local and remote files - samples: Fixes whitespace around while blocks - samples: Adds some basic javadocs and comments - samples: Infer project from env - samples: Updates to use v1 release. - samples: Fixes checkstyle issues. - samples: Adds streaming example and tests. - samples: Nits found in self-review. - samples: Removes commented out code snippet and adds note on async local file limit. - samples: Speech async examples (#612) - samples: Vision speech upgrade (#641) - samples: updating to latest google-cloud-* dependencies (#723) - samples: Upgrades client and addresses changes to long running operations - samples: Adds support for word time offset - samples: Minimizes cloud maven dependencies and fixes lint warnings - samples: Fixes seconds reported in word time offsets and enables maven checks - samples: Updates to highlight word time offsets (#787) - samples: Use only first alternative. Comments for clarity (#837) - samples: Auto-update dependencies. (#853) - samples: Auto-update dependencies. (#912) - samples: Updated mlengine, monitoring, pubsub, spanner, and speech. (#993) - samples: Speech samples (#1036) - samples: Add model selection to streaming sample (#1073) - samples: Model selection (#1074) - samples: Add Auto-Punctuation samples to speech (#1079) - samples: Add samples for enhanced models and metadata (#1093) - samples: Add speech beta samples (#1151) - samples: [DO_NOT_MERGE] Microphone streaming with a 1 minute duration. (#1185) - samples: Speech region tag update (#1188) - samples: updates word time offsets region tag (#1191) - samples: Speech GA - library update (#1212) - samples: Bump QuickStartSample to v1 (#1285) - samples: Infinite Stream recognition (#1297) - samples: Speech multi-channel GA (#1341) - samples: Data logging opt-in is no longer required for enhanced models (#1360) - samples: Updated Infinite streaming sample (#1422) - samples: Revert Tests, product team rolled back changes, Auto Punctuation behavior is back to the expected output (#1428) - samples: Increase timeout to 5 mins (#1453) - samples: Update Recognize.java (#1460) - samples: Add back missing break statement (#1512) - samples: Added command line option class + option to pass different lang code as argument (#1504) - samples: Update a default value to parameter (#1522) - samples: Add samples for speech diarization ga (auto-punctuation samples alrea… (#1744) - samples: speech: add ga samples and fix some flaky tests (#2049) - samples: update shared config (#2443) - samples: speech: make flaky tests generic (#2825) - samples: fix test dependencies - chore(deps): update dependency com.google.cloud:libraries-bom to v9 (#263) - chore(deps): update dependency com.google.cloud:libraries-bom to v10 (#271) - chore(deps): update dependency com.google.cloud:libraries-bom to v11 - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.21 (#294) - chore(deps): update dependency com.google.cloud:libraries-bom to v12 (#298) - test(deps): update dependency junit:junit to v4.13.1 - chore(deps): update dependency com.google.cloud:libraries-bom to v12.1.0 (#310) - chore(deps): update dependency com.google.cloud:libraries-bom to v13 (#321) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.1.0 (#326) - test(deps): update dependency com.google.truth:truth to v1.1 (#322) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.2.0 (#332) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.3.0 (#334) - chore(deps): update dependency com.google.cloud:libraries-bom to v13.4.0 (#338) - chore(deps): update dependency com.google.cloud:libraries-bom to v14 (#347) - chore(deps): update dependency com.google.cloud:libraries-bom to v15 (#350) - chore(deps): update dependency com.google.cloud:libraries-bom to v15.1.0 (#357) - chore(deps): update dependency com.google.cloud:libraries-bom to v16 (#364) - samples: add recognize sample with profanity filter (#376) - samples: refactor quickstart to use a gcs file (#378) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.0 (#389) - samples: add multi region transcribe sample (#394) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.2.1 (#398) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.3.0 (#405) - test(deps): update dependency com.google.truth:truth to v1.1.2 (#407) - chore(deps): update dependency com.google.cloud:libraries-bom to v16.4.0 (#423) - test(deps): update dependency junit:junit to v4.13.2 (#428) - chore(deps): update dependency com.google.cloud:libraries-bom to v17 (#441) - chore(deps): update dependency com.google.cloud:libraries-bom to v18 (#445) - chore(deps): update dependency com.google.cloud:libraries-bom to v18.1.0 (#456) - chore(deps): update dependency com.google.cloud:libraries-bom to v19 (#459) - chore(samples): adds model adaptation sample (#468) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.22 (#482) - chore(deps): update dependency com.google.cloud:libraries-bom to v20 (#486) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.1.0 (#493) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.2.0 (#505) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.3.0 (#514) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.4.0 (#523) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.5.0 (#535) - test(deps): update dependency com.google.truth:truth to v1.1.3 (#537) - chore: change region (#538) - samples: adds export to GCS sample (#544) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.6.0 (#552) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.23 (#551) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.7.0 (#568) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.8.0 (#578) - chore(deps): update dependency com.google.cloud:libraries-bom to v20.9.0 (#589) - chore(deps): update dependency com.google.cloud:libraries-bom to v21 (#625) - chore(deps): update dependency com.google.cloud:libraries-bom to v22 (#650) - chore(deps): update dependency com.google.cloud:libraries-bom to v23 (#663) - chore: migrate to owlbot (#660) - chore(deps): update dependency com.google.cloud:libraries-bom to v23.1.0 (#702) - chore(deps): update dependency com.google.cloud:libraries-bom to v24 (#719) - deps: update dependency commons-cli:commons-cli to v1.5.0 (#720) - sample: Configure polling algorithm in long recognition sample (#464) - chore: cleanup cloud RAD generation (#1269) (#725) - docs(samples): refactors the export-to-gcs sample (#737) - deps: update dependency org.json:json to v20211205 (#745) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.0.24 (#742) - chore(deps): update dependency com.google.cloud.samples:shared-configuration to v1.2.0 (#753) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.0 (#758) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.1 (#759) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.1.2 (#764) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.2.0 (#775) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.3.0 (#794) - chore(deps): update dependency com.google.cloud:libraries-bom to v24.4.0 (#823) - deps: update dependency org.json:json to v20220320 (#835) - chore(deps): update dependency com.google.cloud:libraries-bom to v25 (#834) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.1.0 (#849) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.2.0 (#876) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0 (#883) - chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 (#892) - chore(deps): update dependency com.google.cloud:libraries-bom to v26 (#918) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.0 (#938) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.1 (#941) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.2 (#957) - deps: update dependency org.json:json to v20220924 (#961) - chore(deps): update dependency com.google.cloud:libraries-bom to v26.1.3 (#975) Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [ ] **Tests** pass: `mvn clean verify` **required** - [ ] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [ ] Please **merge** this PR for me once it is approved.

Microphone streaming with a 1 minute duration.

8e0c33b

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2018

Fixed audit issues.

7b6b108

nnegrey suggested changes Aug 16, 2018

View reviewed changes

Fixing issues after review.

838f7a3

nnegrey suggested changes Aug 17, 2018

View reviewed changes

Fixing review issues.

5cf46b9

nnegrey approved these changes Aug 17, 2018

View reviewed changes

nnegrey merged commit a7690e7 into GoogleCloudPlatform:master Aug 17, 2018

Shabirmean pushed a commit that referenced this pull request Nov 17, 2022

samples: [DO_NOT_MERGE] Microphone streaming with a 1 minute duration. (

fc65abd

#1185) * Microphone streaming with a 1 minute duration. * Fixed audit issues. * Fixing issues after review. * Fixing review issues.

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-speech #7437

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO_NOT_MERGE] Microphone streaming with a 1 minute duration. #1185

[DO_NOT_MERGE] Microphone streaming with a 1 minute duration. #1185

nirupa-kumar commented Aug 16, 2018

nirupa-kumar commented Aug 16, 2018

nnegrey left a comment

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nnegrey Aug 16, 2018

nirupa-kumar commented Aug 17, 2018

nnegrey left a comment

nnegrey Aug 17, 2018

nnegrey Aug 17, 2018

nnegrey Aug 17, 2018

nnegrey Aug 17, 2018

[DO_NOT_MERGE] Microphone streaming with a 1 minute duration. #1185

[DO_NOT_MERGE] Microphone streaming with a 1 minute duration. #1185

Conversation

nirupa-kumar commented Aug 16, 2018

nirupa-kumar commented Aug 16, 2018

nnegrey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nirupa-kumar commented Aug 17, 2018

nnegrey left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment