Automl #1158

nirupa-kumar · 2018-07-21T23:51:57Z

Missing Create and Delete Model tests.

googlebot · 2018-07-21T23:52:01Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

nirupa-kumar · 2018-07-21T23:53:52Z

@nnegrey Please review. Let me know if someone else needs to be reviewing this. This is for Vision. I will be adding the others AutoMLs as well.

sirtorry

need syntax approval. only checked tests to make sure important functions are tested. lgtm when tests pass.

need to include tests to model creation and deletion in the future.

googlebot · 2018-07-23T22:50:38Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-07-23T23:04:30Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

googlebot · 2018-07-23T23:09:23Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

googlebot · 2018-07-23T23:26:05Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

tigersoldier · 2018-07-23T23:43:51Z

vision/automl/README.md

+
+#### Import data
+```
+mvn exec:java -Dexec.mainClass="com.google.cloud.vision.samples.automl.DatasetApi" -Dexec.args="import_data gs://java-docs-samples-testing/flower_traindata.csv"


Missing [dataset-id] in the args

tigersoldier · 2018-07-24T00:05:14Z

vision/automl/README.md

+<a href="https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/java-docs-samples&page=editor&open_in_editor=vision/beta/cloud-client/README.md">
+<img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a>
+
+[Google Cloud Vision API][vision] provides feature detection for images.


This summery should be for AutoML Vision, not Vision API in general

tigersoldier · 2018-07-24T00:06:16Z

language/automl/README.md

+<a href="https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/java-docs-samples&page=editor&open_in_editor=vision/beta/cloud-client/README.md">
+<img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a>
+
+[Google Cloud Natural Language API][language] provides feature detection for images.


This API is for AutoML Natural Language, not for the Natural Language API in general.

Also, it's not for detecting images

tigersoldier · 2018-07-24T00:06:57Z

language/automl/README.md

+This sample Java application demonstrates how to access the Cloud Natural Language AutoML API
+using the [Google Cloud Client Library for Java][google-cloud-java].
+
+[language]: https://cloud.google.com/language/docs/


Should be https://cloud.google.com/language/automl/docs/

tigersoldier · 2018-07-24T00:07:12Z

language/automl/README.md

+
+#### Import data
+```
+mvn exec:java -Dexec.mainClass="com.google.cloud.language.samples.DatasetApi" -Dexec.args="import_data gs://java-docs-samples-testing/happiness.csv"


Missing [dataset-id] in args

tigersoldier · 2018-07-24T00:08:06Z

translate/automl/README.md

+<a href="https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/GoogleCloudPlatform/java-docs-samples&page=editor&open_in_editor=vision/beta/cloud-client/README.md">
+<img alt="Open in Cloud Shell" src ="http://gstatic.com/cloudssh/images/open-btn.png"></a>
+
+[Google Cloud Translate API][translate] provides feature AutoML.


Should be AutoML Translation

tigersoldier · 2018-07-24T00:08:45Z

translate/automl/README.md

+
+This sample Java application demonstrates how to access the Cloud Translate AutoML API
+using the [Google Cloud Client Library for Java][google-cloud-java].
+


Missing URLs for [translate] and [google-cloud-java]

tigersoldier · 2018-07-24T00:08:58Z

translate/automl/README.md

+
+#### Import data
+```
+mvn exec:java -Dexec.mainClass="com.google.cloud.translate.samples.DatasetApi" -Dexec.args="import_data gs://java-docs-samples-testing/en-ja.csv"


Missing [dataset-id] in args

tigersoldier · 2018-07-24T00:09:30Z

vision/automl/README.md

+This sample Java application demonstrates how to access the Cloud Vision API
+using the [Google Cloud Client Library for Java][google-cloud-java].
+
+[vision]: https://cloud.google.com/vision/docs/


The URL should be

https://cloud.google.com/vision/automl/docs/

googlebot · 2018-07-24T00:45:56Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

sirtorry · 2018-07-24T01:35:51Z

language/automl/src/test/java/com/google/cloud/language/samples/DatasetApiIT.java

+public class DatasetApiIT {
+
+  private static final String PROJECT_ID = "java-docs-samples-testing";
+  private static final String BUCKET = PROJECT_ID + "-vcm";


vcm should be lcm for language

* Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests

…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <[email protected]> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Andrew Ferlitsch <[email protected]> Co-authored-by: DPEBot <[email protected]> Co-authored-by: nnegrey <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Les Vogel <[email protected]> Co-authored-by: Stephanie Wang <[email protected]> Co-authored-by: Anthony <[email protected]> Co-authored-by: Mike <[email protected]>

* Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests

…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <[email protected]> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Andrew Ferlitsch <[email protected]> Co-authored-by: DPEBot <[email protected]> Co-authored-by: nnegrey <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Les Vogel <[email protected]> Co-authored-by: Stephanie Wang <[email protected]> Co-authored-by: Anthony <[email protected]> Co-authored-by: Mike <[email protected]>

* Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests

…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <[email protected]> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <[email protected]> Co-authored-by: Noah Negrey <[email protected]> Co-authored-by: Andrew Ferlitsch <[email protected]> Co-authored-by: DPEBot <[email protected]> Co-authored-by: nnegrey <[email protected]> Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Les Vogel <[email protected]> Co-authored-by: Stephanie Wang <[email protected]> Co-authored-by: Anthony <[email protected]> Co-authored-by: Mike <[email protected]>

nirupa-kumar added 2 commits July 19, 2018 07:16

Test push

7461899

Vision AutoML

f4531a9

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 21, 2018

nirupa-kumar changed the title ~~Vision Automl~~ Automl Jul 21, 2018

nirupa-kumar added 4 commits July 22, 2018 08:52

Vision AutoML updates + Translate AutoML

96bdd49

Translate README fixes

0efcd8b

Fixing Kokoro failure issue

9150076

Language AutoML

3c7d7aa

kurtisvg requested a review from nnegrey July 23, 2018 15:44

sirtorry self-requested a review July 23, 2018 17:06

Vision AutoML

a2a6d91

sirtorry previously approved these changes Jul 23, 2018

View reviewed changes

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018

Translate AutoML files added

d9216d5

nirupa-kumar dismissed sirtorry’s stale review via d9216d5 July 23, 2018 23:04

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 23, 2018

Merge branch 'master' into automl

6b3320a

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018

nirupa-kumar added 2 commits July 23, 2018 16:25

Triggering tests

4578cc5

Merge remote-tracking branch 'origin/automl' into automl

2e77ccd

googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2018

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 23, 2018

Triggering tests

17f1b5d

tigersoldier reviewed Jul 24, 2018

View reviewed changes

nnegrey added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2018

googlebot removed the cla: no This human has *not* signed the Contributor License Agreement. label Jul 24, 2018

nnegrey approved these changes Jul 24, 2018

View reviewed changes

nnegrey merged commit 8cc8e35 into GoogleCloudPlatform:master Jul 24, 2018

sirtorry reviewed Jul 24, 2018

View reviewed changes

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-automl #7444

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automl #1158

Automl #1158

nirupa-kumar commented Jul 21, 2018

googlebot commented Jul 21, 2018

nirupa-kumar commented Jul 21, 2018 •

edited

Loading

sirtorry left a comment

googlebot commented Jul 23, 2018

googlebot commented Jul 23, 2018

googlebot commented Jul 23, 2018

googlebot commented Jul 23, 2018

tigersoldier Jul 23, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

tigersoldier Jul 24, 2018

googlebot commented Jul 24, 2018

sirtorry Jul 24, 2018


		This sample Java application demonstrates how to access the Cloud Translate AutoML API
		using the [Google Cloud Client Library for Java][google-cloud-java].

Automl #1158

Automl #1158

Conversation

nirupa-kumar commented Jul 21, 2018

googlebot commented Jul 21, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

nirupa-kumar commented Jul 21, 2018 • edited Loading

sirtorry left a comment

Choose a reason for hiding this comment

googlebot commented Jul 23, 2018

googlebot commented Jul 23, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Jul 23, 2018

googlebot commented Jul 23, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

googlebot commented Jul 24, 2018

Choose a reason for hiding this comment

nirupa-kumar commented Jul 21, 2018 •

edited

Loading