Auto-update dependencies.

[dpebot]

Brought to you by your friendly Repository Gardener.

[lesv]

@dpebot Merge when green

[dpebot]

Okay! I'll merge when all statuses are green and all reviewers approve.

[lesv]

- testing container-registry/container-analysis
------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[ERROR] /tmpfs/src/github/java-docs-samples/container-registry/container-analysis/src/main/java/com/example/containeranalysis/Samples.java:[36,28] cannot find symbol
  symbol:   class SubscriptionName
  location: package com.google.pubsub.v1
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.2:compile (default-compile) on project containeranalysis: Compilation failure
[ERROR] /tmpfs/src/github/java-docs-samples/container-registry/container-analysis/src/main/java/com/example/containeranalysis/Samples.java:[36,28] cannot find symbol
[ERROR]   symbol:   class SubscriptionName
[ERROR]   location: package com.google.pubsub.v1

@garrettjonesgoogle Did something change between 0.34.0-beta and 0.37.beta ??

[garrettjonesgoogle]

Yes: https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/CHANGES.md#v0360

[lesv]

@garrettjonesgoogle Thanks - I searched on pubsub and got 0.33, but not pub/sub.

[kurtisvg]

@dzlier-gcp FYI

[dzlier-gcp]

Working on this this morning.

[dzlier-gcp]

Possible cause on this - the account java-docs-samples-testing.iam.gserviceaccount.com only had the Bigtable-Viewer permission, but the test requires at least Bigtable-User with access to the mutateRows permission. Testing this theory now...

[kurtisvg]

@lesv DPEbot just merged this?

[lesv]

@tswast @jonparrott DPEbot is being unhelpful -- merging on RED

[theacodes]

D:

[theacodes]

Looks like a race condition. cla status went green and DPEBot got the notification before CI could start running.

[kurtisvg]

Is there a way to have DPEbot not force merge? The CI status is marked as required, so for a person to pull in that state we have to confirm that we want to override it. Does the DPEBot have a similar safeguard?

[tswast]

I think it's more that DPEbot did merge when green. It was just green before CircleCI could even notify that it was running at all. Probably the fix is to make DPEbot wait on human time scale after things go green (1 minute?)

[kurtisvg]

There is a short gap between when you push a commit, and when the status for the Kokoro CI gets reported. Typically during this time, Github displays the page as mixed green/yellow, and gives a warning saying "As an administrator, you may still merge this pull request.". Administrators of the repo can override this by clicking the button and marking "Use your administrator privileges to merge this pull request.".

Does the mechanism the DPEbot uses to trigger a merge differentiate between a normal merge and one requiring administrative privileges?

[theacodes]

It checks that both the commit status is green and that all requested approvers have approved.

[theacodes]

https://github.com/GoogleCloudPlatform/repository-gardener/blob/master/webhook-app/webhooks.py#L177