-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebSockets samples for Java #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in /flexible, not /appengine -- poorly named - sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL - just fix the parent pom ref, and move to flexible.
<artifactId>websocket</artifactId> | ||
<packaging>war</packaging> | ||
|
||
<parent> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This parent should be:
<!--
The parent pom defines common style checks and testing strategies for our samples.
Removing or replacing it should not affect the execution of the samples in anyway.
-->
<parent>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.8</version>
</parent>
ping |
Ping again |
Closing this as this needs to be re-done and re-tested. The team will re-submit this later. Thanks! |
🤖 I have created a release *beep* *boop* --- ## [3.7.4](https://togithub.com/googleapis/java-dlp/compare/v3.7.3...v3.7.4) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1021](https://togithub.com/googleapis/java-dlp/issues/1021)) ([dc6c270](https://togithub.com/googleapis/java-dlp/commit/dc6c2704358015046b86c193b4b3373f26648855)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Adding doc samples for WebSocket and session affinity support beta release.