Nist tagging #84
Nist tagging #84
Conversation
There was a problem hiding this comment.
Hi, Great start.
Are you all referencing https://github.com/mitre/inspec_tools/blob/master/lib/data/NIST_Map_02052020_CIS_Controls_Version_7.1_Implementation_Groups_1.2.xlsx to get the mappings or most of them?
If you look at the cdc_control data in the benchmark - I think we have all the controls mapped. You shouldn't have any missing mapping - looking at your benchmark v1.2.0 - you seem to have an aligned CDC control for each item - which means you will have a NIST control as well. Also, I don't see the tag cdc_control: [] in the controls as well. Perhaps we should add that as well given we will be reflecting that data anyway to get the NIST tag and rename this PR to 'control mappings'? What do you think?
| @@ -33,6 +33,7 @@ | |||
| tag cis_gcp: control_id.to_s | |||
| tag cis_version: cis_version.to_s | |||
| tag project: gcp_project_id.to_s | |||
| tag nist: [] | |||
There was a problem hiding this comment.
I would guess that all controls can be mapped to a control. The standard pattern is - if its general - use CM-6
| @@ -45,6 +45,7 @@ | |||
| tag cis_gcp: control_id.to_s | |||
| tag cis_version: cis_version.to_s | |||
| tag project: gcp_project_id.to_s | |||
| tag nist: [] | |||
There was a problem hiding this comment.
I would guess that all controls can be mapped to a control. The standard pattern is - if its general - use CM-6
| @@ -41,6 +41,7 @@ | |||
| tag cis_gcp: control_id.to_s | |||
| tag cis_version: cis_version.to_s | |||
| tag project: gcp_project_id.to_s | |||
| tag nist: [] | |||
There was a problem hiding this comment.
| @@ -42,6 +42,7 @@ | |||
| tag cis_gcp: control_id.to_s | |||
| tag cis_version: cis_version.to_s | |||
| tag project: gcp_project_id.to_s | |||
| tag nist: [] | |||
There was a problem hiding this comment.
|
also, don't forget to bump the patch version of the profile once you are done |
|
Once we update heimdall to support CIS controls as well we will need the |
|
/gcbrun |
Added relevant tags and empty arrays