-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added directions for Heimdall Lite #59
Merged
KonradSchieban
merged 7 commits into
GoogleCloudPlatform:master
from
mitre:heimdall-lite
Oct 14, 2020
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b710556
added directions to README and Walkthough to create a json result and…
aaronlippold 355bc5a
fixed markdown syntax in README
aaronlippold 4e926c0
updated shared inputs, readme and walkthrough
aaronlippold 8e63764
fixed grammer and updated to use bullets for items and numbered list …
aaronlippold 246608c
fixed indent issues in inspec.yml
aaronlippold 65f3d02
Merge branch 'master' into heimdall-lite
aaronlippold 4c4f690
added default dummy value for the project_id
aaronlippold File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,51 +13,63 @@ | |
| # limitations under the License. | ||
|
|
||
| name: inspec-gcp-cis-benchmark | ||
| title: "Inspec GCP CIS 1.1 Benchmark" | ||
| maintainer: | ||
| copyright: Google | ||
| copyright_email: [email protected] | ||
| license: Apache-2.0 | ||
| title: "InSpec GCP CIS 1.1 Benchmark" | ||
| maintainer: "Google Cloud Platform" | ||
| copyright: "(c) 2020, Google, Inc." | ||
| copyright_email: "[email protected]" | ||
| license: "Apache-2.0" | ||
| summary: "Inspec Google Cloud Platform Center for Internet Security Benchmark v1.1 Profile" | ||
| version: "1.1.0-17" | ||
| version: 1.1.0-18 | ||
|
|
||
| supports: | ||
| - platform: gcp | ||
|
|
||
| depends: | ||
| - name: inspec-gcp-helpers | ||
| url: https://github.com/GoogleCloudPlatform/inspec-gcp-helpers/archive/v1.0.7.tar.gz | ||
| - name: inspec-gcp-helpers | ||
| url: https://github.com/GoogleCloudPlatform/inspec-gcp-helpers/archive/v1.0.7.tar.gz | ||
|
|
||
| inputs: | ||
| - name: gcp_project_id | ||
| description: 'The GCP project identifier.' | ||
| type: string | ||
| value: "replace_with_your_gcp_project_id" | ||
| - name: cis_version | ||
| description: 'The short version of the GCP CIS Benchmark' | ||
| value: '1.0' | ||
| type: string | ||
| - name: cis_url | ||
| description: 'The URL to the GCP CIS Benchmark' | ||
| value: 'https://www.cisecurity.org/benchmark/google_cloud_computing_platform/' | ||
| type: string | ||
| - name: sa_key_older_than_seconds | ||
| description: 'How many seconds SA keys should not be older than' | ||
| value: 7776000 | ||
| type: numeric | ||
| - name: kms_rotation_period_seconds | ||
| description: 'How many seconds KMS Keys should be last rotated (90 days)' | ||
| value: 7776000 | ||
| type: numeric | ||
| - name: bucket_logging_ignore_regex | ||
| description: 'Ignore this bucket by regex from requiring logging to be enabled' | ||
| # {{gcp_project_id}} and {{bucket_logging_ignore_regex}} | ||
| # must be defined at runtime by the user | ||
| - name: gcp_project_id | ||
| description: "The GCP project identifier." | ||
| type: String | ||
| required: true | ||
|
|
||
| # example = "-logging" | ||
| value: "replace-with-bucket-name-or-partial-match" | ||
| type: string | ||
| - name: gcp_gke_locations | ||
| description: 'The list of regions and/or zone names where GKE clusters are running. An empty array searches all locations' | ||
| type: array | ||
| value: | ||
| - "" | ||
| - name: gce_zones | ||
| description: 'The list of zone names where GCE instances are running. An empty array searches all locations' | ||
| type: array | ||
| value: | ||
| - "" | ||
| # "replace-with-bucket-name-or-partial-match" | ||
| - name: bucket_logging_ignore_regex | ||
| description: "Ignore this bucket by regex from requiring logging to be enabled" | ||
| type: String | ||
| required: false | ||
|
|
||
| - name: cis_version | ||
| description: "The short version of the GCP CIS Benchmark" | ||
| value: "1.0" | ||
| type: String | ||
|
|
||
| - name: cis_url | ||
| description: "The URL to the GCP CIS Benchmark" | ||
| value: "https://www.cisecurity.org/benchmark/google_cloud_computing_platform/" | ||
| type: String | ||
|
|
||
| - name: sa_key_older_than_seconds | ||
| description: "How many seconds SA keys should not be older than" | ||
| value: 7776000 | ||
| type: Numeric | ||
|
|
||
| - name: kms_rotation_period_seconds | ||
| description: "How many seconds KMS Keys should be last rotated (90 days)" | ||
| value: 7776000 | ||
| type: Numeric | ||
|
|
||
| - name: gcp_gke_locations | ||
| description: "The list of regions and/or zone names where GKE clusters are running. An empty array searches all locations" | ||
| type: Array | ||
| value: | ||
| - "" | ||
| - name: gce_zones | ||
| description: "The list of zone names where GCE instances are running. An empty array searches all locations" | ||
| type: Array | ||
| value: | ||
| - "" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is angry there's no value for this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI continues to be angry about not having a value for
gcp_project_id@aaronlippold, I can't push to your branch. Can you please add a commit?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a default dummy value - let me know if that helps. I will see about updating my PRs to ensure you all have push access.