Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install versions of Python not available on Kokoro Windows VM. #1390

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

NickGoog
Copy link
Contributor

@NickGoog NickGoog commented Oct 28, 2021

Windows Python 3.8 tests should run now.

@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@NickGoog NickGoog changed the title Install versions of Python not available on Kokoro Python VM. Install versions of Python not available on Kokoro Windows VM. Oct 28, 2021
Copy link
Collaborator

@dilipped dilipped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@NickGoog NickGoog merged commit 5991dcf into GoogleCloudPlatform:master Oct 28, 2021
@@ -20,6 +20,10 @@ set GsutilRepoDir="T:\src\github\src\gsutil"
set "PyExePath=C:\python%PYMAJOR%%PYMINOR%\python.exe"
set "PipPath=C:\python%PYMAJOR%%PYMINOR%\Scripts\pip.exe"

if not exist %PyExePath% (
choco install python -y --no-progress --version=%PYMAJOR%.%PYMINOR%.0
Copy link
Contributor

@thomasmaclean thomasmaclean Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently there's a proposal to allow for version ranges. I didn't see any linked PR's in this bug, but it's documented here: chocolatey/choco#800

You'd then be able to do something like [%PYMAJOR%.%PYMINOR,%PYMAJOR.%PYNEXTMINOR) assuming you defined PYMINORNEXT to be PYMINOR+1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIPs < Chocos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants