Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve CI errors #8

Merged
merged 14 commits into from
Aug 18, 2021
Merged

Resolve CI errors #8

merged 14 commits into from
Aug 18, 2021

Conversation

jsirianni
Copy link
Contributor

@jsirianni jsirianni commented Aug 16, 2021 •
edited
Loading

  • Check if svc_file or unit_file are nil
  • Update checksums for config files that were recently changed (causing test failures due to checksum mismatch)

@jsirianni jsirianni changed the title Check if svc_file or unit_file are nil Resolve CI errors Aug 16, 2021
qingling128
qingling128 approved these changes Aug 17, 2021
View reviewed changes
Copy link

@qingling128 qingling128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

test/integration/windows/ops-agent/2.0.1/default_test.rb Show resolved Hide resolved
@jsirianni jsirianni marked this pull request as ready for review August 17, 2021 19:49
@jsirianni jsirianni merged commit 468fe04 into master Aug 18, 2021
@jsirianni jsirianni deleted the bug/nil-check branch August 18, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingling128 qingling128 qingling128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirianni @qingling128