Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Guava to 30.0-jre and appengine-plugins-core to 0.9.5 #3650

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Aug 5, 2021

$ git grep '28\.1' shows nothing relevant while $ git grep '30\.0' shows these changes.

@chanseokoh chanseokoh requested a review from a team August 5, 2021 18:02
@google-cla google-cla bot added the cla: yes label Aug 5, 2021
@chanseokoh
Copy link
Contributor Author

Let's see if tests pass.

@chanseokoh chanseokoh changed the title Upgrade appengine-plugins-core to 0.9.5 Upgrade Guava to 30.0-jre and appengine-plugins-core to 0.9.5 Aug 5, 2021
@chanseokoh
Copy link
Contributor Author

Maybe they added @DoNotMock to recent Guava versions. I don't see an easy way to get around it for our test usage, so suppressing it.

1461695 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile (default) on project com.google.cloud.tools.eclipse.googleapis.test: Compilation failure: Compilation failure: 
1461696 [ERROR] /home/travis/build/GoogleCloudPlatform/google-cloud-eclipse/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryTest.java:[59,56] [DoNotMock] Do not mock 'com.google.common.cache.LoadingCache<com.google.cloud.tools.eclipse.googleapis.internal.GoogleApi,com.google.api.client.http.HttpTransport>' (which is-a 'com.google.common.cache.Cache'); com.google.common.cache.Cache is annotated as @DoNotMock: Use CacheBuilder.newBuilder().build().
1461699 [ERROR]     (see https://errorprone.info/bugpattern/DoNotMock)
1461699 [ERROR] /home/travis/build/GoogleCloudPlatform/google-cloud-eclipse/plugins/com.google.cloud.tools.eclipse.googleapis.test/src/com/google/cloud/tools/eclipse/googleapis/internal/GoogleApiFactoryWithProxyServerTest.java:[52,56] [DoNotMock] Do not mock 'com.google.common.cache.LoadingCache<com.google.cloud.tools.eclipse.googleapis.internal.GoogleApi,com.google.api.client.http.HttpTransport>' (which is-a 'com.google.common.cache.Cache'); com.google.common.cache.Cache is annotated as @DoNotMock: Use CacheBuilder.newBuilder().build().
1461702 [ERROR]     (see https://errorprone.info/bugpattern/DoNotMock)

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanseokoh chanseokoh merged commit 2dd2e7a into master Aug 5, 2021
@chanseokoh chanseokoh deleted the upgrade-appengine-plugins-core branch August 5, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants