Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating Servlet 2.5 project with App Engine Java 8 runtime #3324

Merged
merged 6 commits into from
Dec 21, 2018

Conversation

chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Dec 19, 2018

Regarding #3316.

image

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3324 into master will increase coverage by 0.33%.
The diff coverage is 96.77%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3324      +/-   ##
============================================
+ Coverage     69.86%   70.19%   +0.33%     
- Complexity     2951     2995      +44     
============================================
  Files           376      377       +1     
  Lines         13486    13681     +195     
  Branches       1584     1623      +39     
============================================
+ Hits           9422     9604     +182     
- Misses         3434     3448      +14     
+ Partials        630      629       -1
Impacted Files Coverage Δ Complexity Δ
...lipse/appengine/facets/AppEngineStandardFacet.java 73.96% <ø> (+8.32%) 36 <0> (+9) ⬆️
...ipse/appengine/newproject/AppEngineWizardPage.java 82.35% <ø> (ø) 26 <0> (ø) ⬇️
...wproject/standard/AppEngineStandardWizardPage.java 96.15% <100%> (-0.15%) 9 <0> (ø)
...e/appengine/newproject/AppEngineProjectWizard.java 88.57% <100%> (ø) 7 <0> (ø) ⬇️
...ls/eclipse/appengine/newproject/CodeTemplates.java 94.16% <100%> (+9.16%) 30 <2> (+6) ⬆️
...e/appengine/newproject/AppEngineProjectConfig.java 100% <100%> (ø) 18 <2> (ø) ⬇️
...d/tools/eclipse/appengine/ui/AppEngineRuntime.java 100% <100%> (ø) 4 <2> (ø) ⬇️
...va8/AppEngineStandardJre8ProjectFacetDetector.java 75.92% <92.85%> (+5.19%) 9 <4> (+4) ⬆️
...ine/deploy/ui/AppEngineDeployPreferencesPanel.java 85.19% <0%> (-0.17%) 25% <0%> (+2%)
...ls/eclipse/appengine/deploy/DeployPreferences.java 100% <0%> (ø) 34% <0%> (+14%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c7258...bc89ad1. Read the comment docs.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@chanseokoh chanseokoh merged commit 5c43fce into master Dec 21, 2018
@chanseokoh chanseokoh deleted the i3316-java8-servlet25 branch December 21, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants