Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop appengine api when converting old-style library container #3214

Merged
merged 3 commits into from
Jul 7, 2018

Conversation

chanseokoh
Copy link
Contributor

Fixes #3202.

@codecov
Copy link

codecov bot commented Jul 6, 2018

Codecov Report

Merging #3214 into master will increase coverage by 0.2%.
The diff coverage is 28.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3214     +/-   ##
===========================================
+ Coverage     70.05%   70.25%   +0.2%     
- Complexity     2971     2989     +18     
===========================================
  Files           374      374             
  Lines         13533    13583     +50     
  Branches       1624     1638     +14     
===========================================
+ Hits           9480     9543     +63     
+ Misses         3376     3365     -11     
+ Partials        677      675      -2
Impacted Files Coverage Δ Complexity Δ
.../compat/cte13/CloudToolsEclipseProjectUpdater.java 79.24% <ø> (-0.39%) 11 <0> (ø)
...t/cte13/UpdateCloudToolsEclipseProjectHandler.java 9.09% <0%> (-0.91%) 1 <0> (ø)
.../appengine/localserver/launching/LaunchHelper.java 48.19% <50%> (+0.63%) 15 <0> (-1) ⬇️
...calAppEngineServerLaunchConfigurationDelegate.java 61.42% <0%> (-0.3%) 39% <0%> (ø)
...ow/ui/preferences/RunOptionsDefaultsComponent.java 78.57% <0%> (+0.62%) 60% <0%> (+2%) ⬆️
...ls/eclipse/appengine/newproject/CodeTemplates.java 95.7% <0%> (+1.49%) 45% <0%> (+13%) ⬆️
...com/google/cloud/tools/eclipse/util/Templates.java 87.5% <0%> (+5.68%) 4% <0%> (ø) ⬇️
...ipse/dataflow/core/project/DataflowMavenModel.java 63.88% <0%> (+9.72%) 9% <0%> (ø) ⬇️
...aflow/ui/handler/ModifyDataflowVersionHandler.java 20.83% <0%> (+20.83%) 2% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bb7e7...f5d7aa7. Read the comment docs.

Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we cut with this included?

@chanseokoh chanseokoh closed this Jul 7, 2018
@chanseokoh chanseokoh reopened this Jul 7, 2018
@chanseokoh chanseokoh merged commit 6091e3a into master Jul 7, 2018
@chanseokoh chanseokoh deleted the i3202-do-not-drop-appengine-api branch July 7, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants