Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path -> File --> Path Cleanup #381

Closed
akerekes opened this issue Jul 18, 2016 · 2 comments
Closed

Path -> File --> Path Cleanup #381

akerekes opened this issue Jul 18, 2016 · 2 comments
Assignees
@akerekes
Labels
cleanup

Comments

@akerekes
Copy link
Contributor

The PR #378 was used to fix API incompatibilities with CloudSdk. The fix was to use Path instead if File when creating CloudSdk.Builder(). However in some cases we start out with a Path, that was converted to a File and the fix converted it back to a Path, this should be cleaned up.
@akerekes akerekes self-assigned this Jul 18, 2016
@elharo elharo changed the title Cleanup changes Path -> File --> Path Cleanup Jul 21, 2016
@akerekes
Copy link
Contributor Author

Obsolete. Some of the affected code has been deleted, some has already been cleaned up.

@briandealwis
Copy link
Member

João cleaned up a lot of that #335

elharo pushed a commit that referenced this issue Jul 10, 2018
@TadCordle
Consolidate ImageFormat enum definitions (#381)
c478c21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akerekes akerekes

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@briandealwis @akerekes