Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a verification check when a new GAE runtime is created #375

Closed
nbashirbello opened this issue Jul 15, 2016 · 6 comments
Closed

Add a verification check when a new GAE runtime is created #375

nbashirbello opened this issue Jul 15, 2016 · 6 comments
Assignees
Labels

Comments

@nbashirbello
Copy link
Contributor

When creating an app-tools-lib-for-java runtime, there is no check that the cloud sdk exists on the system (that we have a valid path to the cloud sdk install). This step is done when the user attempts to run/debug the runtime (check is done CloudSdk.Builder#build).

Should we be calling PathResolver.INSTANCE.getCloudSdkPath() to check that is returns a path when a new runtime is created? If we do this, the user can input the path if we didn't find it or prompt the user to install gcloud if they dont have it.

@nbashirbello
Copy link
Contributor Author

@elharo @briandealwis

@elharo
Copy link
Contributor

elharo commented Jul 15, 2016

How would this affect he new project wizard which creates a (possibly invalid) runtime?

@nbashirbello
Copy link
Contributor Author

We could have the check in the new project wizard too. If we cannot resolve the location of the cloud sdk (that is after the path resolver and after prompting the user for the location), the new project creation will fail. My thought is you cannot use the App Engine features without the cloud sdk and user can always create a dynamic web module and install the facet later after they install cloud sdk.

@briandealwis
Copy link
Member

@nbashirbello use CloudSdkPrompter — it does what you're looking for.

@elharo
Copy link
Contributor

elharo commented Oct 31, 2016

@nbashirbello Is this now done and/or obsolete?

@nbashirbello
Copy link
Contributor Author

This bug still exists. I will work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants