-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add clear export subscription samples #3159
feat(pubsub): add clear export subscription samples #3159
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only nits. Feel free to merge when status is green.
…-samples into feat-pubsub-clear-bq-sub
Hi @hongalex, This PR looks to be pretty stale, and need some attention to get the tests passing. I'll move it to Draft for now, but please reach out if you need any help getting this PR merged. |
93fe9b0
to
edc3292
Compare
Closing due to staleness. |
This PR corresponds to the changes in googleapis/google-cloud-go#8040. We currently were not catching an issue where clearing bigquery subscription fails. This adds the appropriate sample + test to catch this. A similar sample and test is added for Push (to endpoint) subscriptions.
This PR also switches the BQ dataset/table used from dynamically created to a reused one. Since we aren't actually writing to these tables, there's no harm in reusing a predefined table. This prevents a slow leakage of tables/datasets over time when tests invocations inevitably fail.