Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: commit logging agent script to repo #449

Merged
merged 12 commits into from
Apr 1, 2022
Merged

Conversation

busunkim96
Copy link
Contributor

Fixes b/210461441.

An unvendored shell script (not in your repo) is being executed using curl | bash. All executed source should be commited to your source repository.

This commits what appears to be the latest iteration of the logging agent to the repository.

I visited https://cloud.google.com/logging/docs/agent/logging/installation first, which has https://dl.google.com/cloudagents/add-logging-agent-repo.sh. However, it has this note at the top, so I switched to the Ops Agent:

Key Point: While this agent is still supported, we recommend that you use the Ops Agent for new workloads and eventually transition your existing VMs to use the new agent. The Ops Agent is the eventual replacement for the existing Google Cloud's operations suite agents, and it offers a simple user experience with metrics and logging combined into a single agent.

@busunkim96 busunkim96 requested a review from a team as a code owner April 1, 2022 15:50
@busunkim96 busunkim96 changed the title Commit logging agent script to repo chore: commit logging agent script to repo Apr 1, 2022
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@busunkim96 busunkim96 merged commit a361d19 into main Apr 1, 2022
@busunkim96 busunkim96 deleted the startup-script-fix branch April 1, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants