Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add finance advisor spanner demo #901

Merged
merged 86 commits into from
Aug 12, 2024
Merged

feat: Add finance advisor spanner demo #901

merged 86 commits into from
Aug 12, 2024

Conversation

anirbanbagchi1979
Copy link
Contributor

@anirbanbagchi1979 anirbanbagchi1979 commented Jul 25, 2024 •
edited
Loading

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • You are listed as the author in your notebook or README file.
    • Your account is listed in CODEOWNERS for the file(s).
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
  • Ensure the tests and linter pass (Run nox -s format from the repository root to format).
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@anirbanbagchi1979 anirbanbagchi1979 requested review from a team and alokpattani July 25, 2024 04:05
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 9, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
holtskinner
holtskinner reviewed Aug 12, 2024
View reviewed changes
gemini/sample-apps/finance-advisor-spanner/css.py Outdated Show resolved Hide resolved
gemini/sample-apps/finance-advisor-spanner/graph_viz.html Outdated
Comment on lines 14 to 15
<!-- <link rel="stylesheet" href="../node_modules/vis/dist/vis.min.css" type="text/css" />
<script type="text/javascript" src="../node_modules/vis/dist/vis.js"> </script>-->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove commented out code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file deleted

gemini/sample-apps/finance-advisor-spanner/graph_viz.html Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still quite a lot of empty lines/spacing issues. Can

gemini/sample-apps/finance-advisor-spanner/graph_viz.html Outdated Show resolved Hide resolved
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@github-actions github-actions bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 12, 2024
@holtskinner holtskinner merged commit f0caf08 into main Aug 12, 2024
24 checks passed
@holtskinner holtskinner deleted the finance-advisor-spanner branch August 12, 2024 15:50
cachatj pushed a commit to cachatj/GCP-generative-ai that referenced this pull request Sep 1, 2024
@anirbanbagchi1979 @gcf-owl-bot @holtskinner
feat: Add finance advisor spanner demo (GoogleCloudPlatform#901)
263c6fc 

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Holt Skinner <[email protected]>
Co-authored-by: Holt Skinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtskinner holtskinner holtskinner requested changes

@alokpattani alokpattani Awaiting requested review from alokpattani

Assignees

@anirbanbagchi1979 anirbanbagchi1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anirbanbagchi1979 @holtskinner