Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Create Data Store/Search Notebook #1366

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

holtskinner
Copy link
Collaborator

Fixes #1339

  • Added ADC authentication
  • Changed Search to use Engine

@holtskinner holtskinner requested a review from a team as a code owner October 31, 2024 18:04
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Fixes #1339

- Added ADC authentication
- Changed Search to use Engine
@holtskinner holtskinner merged commit 29dfa49 into main Oct 31, 2024
8 checks passed
@holtskinner holtskinner deleted the rag-import-fix branch October 31, 2024 18:05
inardini pushed a commit to inardini/generative-ai that referenced this pull request Dec 7, 2024
Fixes GoogleCloudPlatform#1339

- Added ADC authentication
- Changed Search to use Engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant