Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: CONTRIBUTING doc missing instructions for nox #820

Closed
1 task done
ianlewis opened this issue Jun 28, 2024 · 0 comments · Fixed by #936
Closed
1 task done

[Bug]: CONTRIBUTING doc missing instructions for nox #820

ianlewis opened this issue Jun 28, 2024 · 0 comments · Fixed by #936

Comments

@ianlewis
Copy link
Contributor

ianlewis commented Jun 28, 2024 •
edited by holtskinner
Loading

File Name

CONTRIBUTING.md

What happened?

The PR template asks contributors to make sure that nox -s format passes locally when making changes however the CONTRIBUTING.md makes no reference to how to install the necessary tools.

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@holtskinner holtskinner mentioned this issue Aug 8, 2024
Merged
holtskinner added a commit that referenced this issue Aug 8, 2024
@holtskinner
fix: Update Contributing Guide to show notebook linter command and `n…
e4ad726 
…ox -s format` (#936)

Fixes #820 🦕
gabrielahrlr pushed a commit to gabrielahrlr/generative-ai that referenced this issue Aug 12, 2024
@holtskinner @gabrielahrlr
fix: Update Contributing Guide to show notebook linter command and `n…
6b8d93f 
…ox -s format` (GoogleCloudPlatform#936)

Fixes GoogleCloudPlatform#820 🦕
cachatj pushed a commit to cachatj/GCP-generative-ai that referenced this issue Sep 1, 2024
@holtskinner
fix: Update Contributing Guide to show notebook linter command and `n…
6f6a29d 
…ox -s format` (GoogleCloudPlatform#936)

Fixes GoogleCloudPlatform#820 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ianlewis