Skip to content

Commit

Permalink
fix: remove the num_template_per_step param in all notebooks (#1574)
Browse files Browse the repository at this point in the history
# Description
Remove the `num_template_eval_per_step` parameter in all the notebooks.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make
sure it goes smoothly:

- [x] Follow the [`CONTRIBUTING`
Guide](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/CONTRIBUTING.md).
- [x] You are listed as the author in your notebook or README file.
- [x] Your account is listed in
[`CODEOWNERS`](https://github.com/GoogleCloudPlatform/generative-ai/blob/main/.github/CODEOWNERS)
for the file(s).
- [x] Make your Pull Request title in the
<https://www.conventionalcommits.org/> specification.
- [x] Ensure the tests and linter pass (Run `nox -s format` from the
repository root to format).
- [x] Appropriate docs were updated (if necessary)
  • Loading branch information
want-to-be-relaxed authored Dec 24, 2024
1 parent 6384e5c commit 818b589
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,6 @@
" project=PROJECT_ID, # Google Cloud project ID. String.\n",
" # (Optional) Advanced configuration\n",
" num_steps=10, # Number of iterations in instruction optimization mode. Integer between 10 and 20.\n",
" num_template_eval_per_step=2, # Number of system instructions generated and evaluated in instruction and instruction_and_demo mode. Integer between 1 and 4.\n",
" num_demo_set_candidates=10, # Number of demonstrations evaluated in instruction and instruction_and_demo mode. Integer between 10 and 30.\n",
" demo_set_size=3, # Number of demonstrations generated per prompt. Integer between 3 and 6.\n",
" target_model_location=\"us-central1\", # Location of the target model. String. Default us-central1.\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,6 @@
" project=PROJECT_ID, # Google Cloud project ID. String.\n",
" # (Optional) Advanced configuration\n",
" num_steps=10, # Number of iterations in instruction optimization mode. Integer between 10 and 20.\n",
" num_template_eval_per_step=2, # Number of system instructions generated and evaluated in instruction and instruction_and_demo mode. Integer between 1 and 4.\n",
" num_demo_set_candidates=10, # Number of demonstrations evaluated in instruction and instruction_and_demo mode. Integer between 10 and 30.\n",
" demo_set_size=3, # Number of demonstrations generated per prompt. Integer between 3 and 6.\n",
" target_model_location=\"us-central1\", # Location of the target model. String. Default us-central1.\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -825,7 +825,6 @@
" project=PROJECT_ID, # Google Cloud project ID. String.\n",
" # (Optional) Advanced configuration\n",
" num_steps=10, # Number of iterations in instruction optimization mode. Integer between 10 and 20.\n",
" num_template_eval_per_step=2, # Number of system instructions generated and evaluated in instruction and instruction_and_demo mode. Integer between 1 and 4.\n",
" num_demo_set_candidates=10, # Number of demonstrations evaluated in instruction and instruction_and_demo mode. Integer between 10 and 30.\n",
" demo_set_size=3, # Number of demonstrations generated per prompt. Integer between 3 and 6.\n",
" target_model_location=\"us-central1\", # Location of the target model. String. Default us-central1.\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,6 @@
" project=PROJECT_ID, # Google Cloud project ID. String.\n",
" # (Optional) Advanced configuration\n",
" num_steps=10, # Number of iterations in instruction optimization mode. Integer between 10 and 20.\n",
" num_template_eval_per_step=2, # Number of system instructions generated and evaluated in instruction and instruction_and_demo mode. Integer between 1 and 4.\n",
" num_demo_set_candidates=10, # Number of demonstrations evaluated in instruction and instruction_and_demo mode. Integer between 10 and 30.\n",
" demo_set_size=3, # Number of demonstrations generated per prompt. Integer between 3 and 6.\n",
" target_model_location=\"us-central1\", # Location of the target model. String. Default us-central1.\n",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@
"source": [
"# @markdown **Instruction Optimization Configs**: <br/>\n",
"NUM_INST_OPTIMIZATION_STEPS = 10 # @param {type:\"integer\"}\n",
"NUM_TEMPLATES_PER_STEP = 2 # @param {type:\"integer\"}\n",
"\n",
"# @markdown **Demonstration Optimization Configs**: <br/>\n",
"NUM_DEMO_OPTIMIZATION_STEPS = 10 # @param {type:\"integer\"}\n",
Expand All @@ -294,9 +293,7 @@
"\n",
"# @markdown **Misc Configs**: <br/>\n",
"PLACEHOLDER_TO_VALUE = \"{}\" # @param\n",
"RESPONSE_MIME_TYPE = (\n",
" \"text/plain\" # @param [\"text/plain\", \"application/json\", \"text/x.enum\"]\n",
")\n",
"RESPONSE_MIME_TYPE = \"text/plain\" # @param [\"text/plain\", \"application/json\", \"text/x.enum\"]\n",
"RESPONSE_SCHEMA = \"\"\n",
"TARGET_LANGUAGE = \"English\" # @param [\"English\", \"French\", \"German\", \"Hebrew\", \"Hindi\", \"Italian\", \"Japanese\", \"Korean\", \"Portuguese\", \"Simplified Chinese\", \"Spanish\", \"Traditional Chinese\"]\n",
"TOOLS = \"\" # @param\n",
Expand Down Expand Up @@ -365,7 +362,6 @@
" \"demo_set_size\": NUM_DEMO_PER_PROMPT,\n",
" \"aggregation_type\": METRIC_AGGREGATION_TYPE,\n",
" \"data_limit\": 50,\n",
" \"num_template_eval_per_step\": NUM_TEMPLATES_PER_STEP,\n",
" \"input_data_path\": input_data_path,\n",
" \"output_path\": output_path,\n",
" \"response_mime_type\": RESPONSE_MIME_TYPE,\n",
Expand Down

0 comments on commit 818b589

Please sign in to comment.