Query.next_page() should produce a null cursor if not set on response

[dhermes]

Currently it returns an empty string.

[dhermes]

Noticed this during #1055

[dhermes]

OK, checking response.batch.HasField('end_cursor') is always True, even when the cursor is ''.

@tseaver WDYT we should do here? I think returning '' and setting it as the _start_cursor value on an Iterator is not the right move.

[tseaver]

@dhermes While investigating, it just seemed easier to make the change (to ensure I didn't break anything).

[dhermes]

No worries.

[dhermes]

@tseaver Turns out this issue still open.

Remaining concern: Should Connection.run_query check if the end_cursor is set on the response.batch?

[dhermes]

@tseaver Bump

[tseaver]

I assume you are worried about this line. If the response protobuf doesn't have a value set, we get a None there, right? That seems like the right sentinel to me.

[dhermes]

See what I said above:

checking response.batch.HasField('end_cursor') is always True, even when the cursor is ''.

[lukesneeringer]

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.

As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.

My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.

Thank you!