This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
Create test apps #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gcloud-java Test Applications | ||
| ============================= | ||
|
|
||
| This folder contains examples of end-to-end test apps for gcloud-java. |
There was a problem hiding this comment.
I would not call it end-to-end test yet (though we can say that it could be used to end-to-end test).
ajkannan
force-pushed
the
add-tests-apps
branch
from
581866c to
ae229b6
Compare
ajkannan
force-pushed
the
add-tests-apps
branch
from
626d003 to
59e0d0a
Compare
| @Override | ||
| public void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException { | ||
| PrintWriter responseWriter = resp.getWriter(); | ||
| String projectId = null; |
There was a problem hiding this comment.
Nit, projectId and credentials could be moved to the else clause.
|
Looks good. Few more comments. |
…ted, and force delete storage's bucket after test is finished
|
@aozarov Added a commit to address your previous round of comments. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.