fix: Add a DummyErrorHandler (#137)

* Remove unused imports * Add failing test * Add DummyErrorHandler
GoogleCloudPlatform · Jul 21, 2021 · 9ea8dd2 · 9ea8dd2
1 parent 54d87d0
commit 9ea8dd2
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/src/functions_framework/__init__.py b/src/functions_framework/__init__.py
@@ -348,3 +348,14 @@ def __call__(self, *args, **kwargs):
 
 
 app = LazyWSGIApp()
+
+
+class DummyErrorHandler:
+    def __init__(self):
+        pass
+
+    def __call__(self, *args, **kwargs):
+        return self
+
+
+errorhandler = DummyErrorHandler()
diff --git a/tests/test_cloudevent_functions.py b/tests/test_cloudevent_functions.py
@@ -16,9 +16,9 @@
 
 import pytest
 
-from cloudevents.http import CloudEvent, from_http, to_binary, to_structured
+from cloudevents.http import CloudEvent, to_binary, to_structured
 
-from functions_framework import LazyWSGIApp, create_app, exceptions
+from functions_framework import create_app
 
 TEST_FUNCTIONS_DIR = pathlib.Path(__file__).resolve().parent / "test_functions"
 TEST_DATA_DIR = pathlib.Path(__file__).resolve().parent / "test_data"

diff --git a/tests/test_functions.py b/tests/test_functions.py
@@ -25,7 +25,7 @@
 
 import functions_framework
 
-from functions_framework import LazyWSGIApp, create_app, exceptions
+from functions_framework import LazyWSGIApp, create_app, errorhandler, exceptions
 
 TEST_FUNCTIONS_DIR = pathlib.Path.cwd() / "tests" / "test_functions"
 
@@ -454,6 +454,12 @@ def test_lazy_wsgi_app(monkeypatch, target, source, signature_type):
     ]
 
 
+def test_dummy_error_handler():
+    @errorhandler("foo", bar="baz")
+    def function():
+        pass
+
+
 def test_class_in_main_is_in_right_module():
     source = TEST_FUNCTIONS_DIR / "module_is_correct" / "main.py"
     target = "function"