Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add release candidate validation #124

Merged
merged 3 commits into from
Apr 19, 2022

Conversation

anniefu
Copy link
Contributor

@anniefu anniefu commented Apr 12, 2022

Runs buildpack integration tests before the release-please GitHub Action
creates a release candidate PR.

See functions-framework-conformance builidpack integration workflow PR for more information.

Runs buildpack integration tests before the release-please GitHub Action
creates a release candidate PR.
@anniefu anniefu requested a review from grant April 12, 2022 20:34
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a detailed PR description?

What is this really testing and what type of failures can we now uniquely detect with this action?

Is there an overall design for this validation work? There seems to be a lot of hardcoded values here.

@anniefu
Copy link
Contributor Author

anniefu commented Apr 12, 2022

Can you add a detailed PR description?

What is this really testing and what type of failures can we now uniquely detect with this action?

Is there an overall design for this validation work? There seems to be a lot of hardcoded values here.

Added the link to the functions framework conformance PR that describes the integration test.

The only hardcoded value that is unfortunate is the builder tag, which can hopefully be removed if GCF tags their builders with latest. Otherwise, the values you see input are the same as required for conformance.yml or any conformance test run.

@anniefu anniefu requested a review from grant April 12, 2022 22:52
Copy link
Contributor

@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not sure how this will orchestrate in practice, but we can try it out.

.github/workflows/release-please.yml Show resolved Hide resolved
@anniefu anniefu merged commit 4f5e934 into GoogleCloudPlatform:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants