Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Relink config files only once #289

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

akinfermo
Copy link
Collaborator

RelinkConfigFiles can sometimes get called by both the dbdaemon and init_oracle. Only one call to RelinkConfigFiles is necessary. Having two calls can lead to race conditions.

Delete unused parameter for reinitUnseededHost() function.

b/260762391

Change-Id: I03031bf980c9b1b95239b81af2029a179519088d

RelinkConfigFiles can sometimes get called by both the dbdaemon and init_oracle. Only one call to RelinkConfigFiles is necessary. Having two calls can lead to race conditions.

Delete unused parameter for reinitUnseededHost() function.

b/260762391

Change-Id: I03031bf980c9b1b95239b81af2029a179519088d
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akinfermo
Copy link
Collaborator Author

/test operator-oss-presubmit

4 similar comments
@akinfermo
Copy link
Collaborator Author

/test operator-oss-presubmit

@akinfermo
Copy link
Collaborator Author

/test operator-oss-presubmit

@akinfermo
Copy link
Collaborator Author

/test operator-oss-presubmit

@akinfermo
Copy link
Collaborator Author

/test operator-oss-presubmit

@akinfermo akinfermo merged commit 78fe478 into GoogleCloudPlatform:main Nov 30, 2022
@akinfermo akinfermo deleted the fix/relink-config branch November 30, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants