Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting impdp specific options on import #284

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

kurt-google
Copy link
Collaborator

This enables a selected subset of impdb specific options on import that we know are safe to support more common import usages.

bug: 254697198
Change-Id: I5e0b8e8914c996f53319b822463e1f9a29e0126e

This enables a selected subset of impdb specific options on import that
we know are safe to support more common import usages.

bug: 254697198
Change-Id: I5e0b8e8914c996f53319b822463e1f9a29e0126e
Copy link
Collaborator

@akinfermo akinfermo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akinfermo, kurt-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kurt-google
Copy link
Collaborator Author

Woops wrong button.

/retest

@kurt-google kurt-google merged commit 88f24fb into GoogleCloudPlatform:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants