Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parameter for detect intent #207

Closed
wants to merge 8 commits into from
Closed

Add Parameter for detect intent #207

wants to merge 8 commits into from

Conversation

Naveenkm13
Copy link
Collaborator

No description provided.

@Naveenkm13 Naveenkm13 linked an issue Jul 16, 2024 that may be closed by this pull request
[FR] Support of parameter passing to detect intent in evaluation_tool_autoeval_colab. #185
Closed
@Naveenkm13 Naveenkm13 requested a review from Mrpatekful July 16, 2024 15:04
@kmaphoenix kmaphoenix self-requested a review July 18, 2024 16:33
@kmaphoenix kmaphoenix self-assigned this Jul 18, 2024
kmaphoenix
kmaphoenix approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM<

@kmaphoenix
Copy link
Member

@Naveenkm13 there's a conflict with your changes to this notebook and recent changes that were already merged in #210

Can you see if the changes in #210 are sufficient? If yes, go ahead and delete this branch / PR.
Otherwise, please rebase your changes and update with the current changes to main included with your PR.

@kmaphoenix kmaphoenix self-requested a review July 18, 2024 16:45
kmaphoenix
kmaphoenix requested changes Jul 18, 2024
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase and update with changes to main

@Naveenkm13 Naveenkm13 requested a review from kmaphoenix July 19, 2024 09:44
@Naveenkm13
Copy link
Collaborator Author

Rebased and updated the required changes

@Naveenkm13 Naveenkm13 removed the request for review from Mrpatekful July 19, 2024 09:46
@Naveenkm13
Copy link
Collaborator Author

rebase and update with changes to main

Completed..

@Naveenkm13 Naveenkm13 closed this Jul 29, 2024
@kmaphoenix kmaphoenix deleted the 185-fr-support-of-parameter-passing-to-detect-intent-in-evaluation_tool_autoeval_colab branch August 23, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaphoenix kmaphoenix Awaiting requested review from kmaphoenix

Assignees

@kmaphoenix kmaphoenix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Support of parameter passing to detect intent in evaluation_tool_autoeval_colab.
2 participants
@Naveenkm13 @kmaphoenix