Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add creds to the constructors #204

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Add creds to the constructors #204

merged 2 commits into from
Jul 18, 2024

Conversation

MRyderOC
Copy link
Collaborator

Added creds to constructors of core.Tools and core.Sessions in case the user wanted to pass service_account.Credentials.

@kmaphoenix kmaphoenix self-assigned this Jul 18, 2024
kmaphoenix
kmaphoenix approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmaphoenix kmaphoenix added auth sessions Relating to DFCX Sessions Class Generative Features Any features that utilizes LLMs tools labels Jul 18, 2024
@kmaphoenix kmaphoenix merged commit 6f4c1a1 into main Jul 18, 2024
5 checks passed
@kmaphoenix kmaphoenix deleted the bug/missing-creds branch July 18, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaphoenix kmaphoenix kmaphoenix approved these changes

Assignees

@kmaphoenix kmaphoenix

Labels
auth Generative Features Any features that utilizes LLMs sessions Relating to DFCX Sessions Class tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MRyderOC @kmaphoenix