Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the correct parameter to _update_kwargs #174

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Pass the correct parameter to _update_kwargs #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dfcx_scrapi/core/environments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,10 +309,10 @@ def update_environment(
if environment_obj:
env = environment_obj
env.name = environment_id
mask = self._update_kwargs(environment_obj)
mask = self._update_kwargs(env)
elif kwargs:
env = self.get_environment(environment_id)
mask = self._update_kwargs(environment_obj, **kwargs)
mask = self._update_kwargs(env, **kwargs)

request = types.environment.UpdateEnvironmentRequest(
environment=env, update_mask=mask)
Expand Down
4 changes: 2 additions & 2 deletions src/dfcx_scrapi/core/test_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,12 +462,12 @@ def update_test_case(
if obj:
test_case = obj
test_case.name = test_case_id
mask = self._update_kwargs(obj)
mask = self._update_kwargs(test_case)
elif kwargs:
if not test_case_id:
test_case_id = self.test_case_id
test_case = self.get_test_case(test_case_id)
mask = self._update_kwargs(obj, **kwargs)
mask = self._update_kwargs(test_case, **kwargs)

request = types.test_case.UpdateTestCaseRequest(
test_case=test_case, update_mask=mask)
Expand Down
Loading