fix:_check_proto_obj_attr_exist does not handle None properly

[gyar-denim]

None check in _check_proto_obj_attr_exist is not handled properly.

# is buggy for None check.
if not obj:  

# correct way
if obj is None:

# Below code makes one example why it is buggy. 

from dfcx_scrapi.builders.fulfillments import FulfillmentBuilder
from google.cloud.dialogflowcx_v3beta1.types import Fulfillment


def main():
    fulfilment_builder = FulfillmentBuilder()
    fullfilment_obj = fulfilment_builder.create_new_proto_obj()
    assert fulfilment_builder.proto_obj is not None
    assert isinstance(fulfilment_builder.proto_obj, Fulfillment)
    assert isinstance(fullfilment_obj, Fulfillment)

    assert (not fulfilment_builder.proto_obj) is True
    # fails because there is a bug in _check_proto_obj_attr_exist()
    fulfilment_builder._check_proto_obj_attr_exist()

    """
        def _check_proto_obj_attr_exist(self):
        
        # BUG HERE : should be if self.proto_obj is None
        
        if not self.proto_obj:
            raise ValueError(
                "There is no proto_obj!"
                "\nUse `create_new_proto_obj` or `load_proto_obj` to continue."
            )
        elif not isinstance(self.proto_obj, self._proto_type):  # pylint: disable=W1116
            raise ValueError(
                f"proto_obj is not {self._proto_type_str} type."
                "\nPlease create or load the correct type to continue."
            )
    """


if __name__ == "__main__":
    main()

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[MRyderOC]

Thanks for pointing this out. This was a known issue but unfortunately I forgot to solve the bug. Please sign the CLA using the email you've created your GitHub account with so we can merge the PR.

[gyar-denim]

I signed the CLA, pipeline still shows the error. Does the ci/cd pipeline automatically get triggered by signing CLA? If not, can you re-trigger the workflow? thanks, Yar

…

On Wed, Jan 10, 2024 at 3:37 PM Milad ***@***.***> wrote: Thanks for pointing this out. This was a known issue but unfortunately I forgot to solve the bug. Please sign the CLA <https://cla.developers.google.com/about/google-individual> using the email you've created your GitHub account with so we can merge the PR. — Reply to this email directly, view it on GitHub <#166 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BDVQYJZX6SHMQPP3H4NKKETYN4CZJAVCNFSM6AAAAABBVOGDLWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVG43TIMRRGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Gokberk Yar *Senior Software Engineer* Denim Health <https://www.denimhealth.com/>

[MRyderOC]

thanks for signing that!
@kmaphoenix LGTM!