Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/get test cases map #159

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Feature/get test cases map #159

merged 3 commits into from
Feb 8, 2024

Conversation

jkshj21
Copy link
Collaborator

@jkshj21 jkshj21 commented Dec 19, 2023

I added a function that returns the test cases map in https://github.com/GoogleCloudPlatform/dfcx-scrapi/blob/main/src/dfcx_scrapi/core/test_cases.py

the name of the function is "get_test_cases_map"

The description is like below:

    """Exports Agent Test Cases and UUIDs into a user friendly dict.

    Args:
      agent_id: The agent to create the test case for. Format:
          `projects/<Project ID>/locations/<Location ID>/agents/<Agent ID>`
      reverse: (Optional) Boolean flag to swap key:value -> value:key
    Returns:
      Dict containing Test Case UUIDs as keys and display names as values.
    """

@jkshj21 jkshj21 requested a review from MRyderOC December 19, 2023 23:29
@MRyderOC
Copy link
Collaborator

Made some typo changes on the last commit

Copy link
Collaborator

@MRyderOC MRyderOC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MRyderOC
Copy link
Collaborator

@kmaphoenix Ready to merge!

Copy link
Member

@kmaphoenix kmaphoenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kmaphoenix kmaphoenix merged commit d13e3d2 into main Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants